You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi! In order to fix http-rs/surf#97 and other issues, we've been working on a new set of libraries, including http-types. One feature this includes is that the Body type implements Send + Sync.
However as we've started migrating to http-types (http-rs/http-client#22), we've noticed that isahc::Body is !Sync. We were wondering if it'd be possible to change this? Thanks heaps!
The text was updated successfully, but these errors were encountered:
Seems reasonable to me. The only thing preventing it from being Sync currently is that you are allowed to create a Body from an AsyncRead that doesn't implement Sync, but this is probably very uncommon. Since this is a breaking change, we can add the additional restriction in the 0.9 release.
Hi! In order to fix http-rs/surf#97 and other issues, we've been working on a new set of libraries, including http-types. One feature this includes is that the
Body
type implementsSend + Sync
.However as we've started migrating to
http-types
(http-rs/http-client#22), we've noticed thatisahc::Body
is!Sync
. We were wondering if it'd be possible to change this? Thanks heaps!The text was updated successfully, but these errors were encountered: