-
-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implementation of the generalized associahedron as a polyhedral complex #10817
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Dependencies: #10538 |
comment:5
As many files are touched in #11187, this "depends" on it to apply properly. |
comment:6
Apply trac_10817-generalized_associahedra-cs.patch |
comment:8
Let us try without the dependency, which is not obviously needed. Apply trac_10817-generalized_associahedra-cs.patch |
Changed dependencies from #11187 to none |
comment:9
well, too bad, it does really depends on #11187 |
Dependencies: #11187 |
comment:10
Replying to @fchapoton:
I removed the dependencies so we can get it done without waiting for the other patch - Thanks for looking at it! |
Changed dependencies from #11187 to none |
comment:11
Apply trac_10817-generalized_associahedra-cs.patch |
This comment has been minimized.
This comment has been minimized.
Reviewer: Frédéric Chapoton, Nicolas M. Thiéry |
comment:14
A review has been done, and a reviewer patch follows soon. |
comment:15
I just pushed the reviewer patch on the sage-combinat server; please check if you agree with it. I still want to have a last look, but this may not occur before next week (vacations here). Cheers, |
comment:16
Replying to @nthiery:
Ok, I finally could do it. The patch is on the queue. If you are happy with it, you may fold the two patches, upload them here, and set a positive review on my behalf. |
comment:17
Thanks for the review -- you should add yourself as an author actually... . I set a positive review on Nicolas' behalf. Best, Christian |
comment:18
For the record: all tests pass on 5.0 beta4, with the following patches applied:
Most of the above patches are either orthogonal or already merged in beta5, so I assume the test pass without them too. |
comment:19
Replying to @stumpc5:
Bah, just my reviewer's job. You drove this patch through! |
comment:20
There is a doctest failure on hawk (OpenSolaris 06.2009-32):
|
comment:21
Replying to @jdemeyer:
The buildbot doesn't find the failure, and the list has actually the same content. So the problem must be something with the cmp of inequalities. I wouldn't know how to fix that in this patch actually. Best, Christian |
comment:22
On Cicero (Linux i386):
|
comment:23
Replying to @jdemeyer: I updated the patch with this order in the sorted list of inequalities. But now I see that the two machines you are using sort this list differently - in particular, we have no chance to get no failure on any of the two machines you used... Any suggestions? |
comment:24
Replying to @stumpc5:
What about:
Then the result should be sorted according to their string |
Attachment: trac_10817-generalized_associahedra-cs.patch.gz |
comment:25
Replying to @nthiery:
Done - how can I know that string representations should be platform independent and some others aren't? Thanks! Christian |
comment:26
Replying to @stumpc5:
Thanks! Positive review, assuming the tests pass.
Because:
|
comment:27
Replying to @nthiery:
The buildbot somehow doesn't like the test
I guess, you added it, didn't you? On my 5.0.beta6, it passed though. Best, Christian |
comment:28
Replying to @stumpc5:
Indeed. Python has been upgraded to 2.7 in Sage 5.0. I guess this syntax for format was not yet supported in Python 2.6. Let's just wait for the buildbot to run on 5.0. |
Merged: sage-5.0.beta8 |
The patch contains the implementation of the generalized associahedron, as constructed in [CFZ] Chapoton, Fomin, Zelevinsky - Polytopal realizations of the generalized associahedra, http://arxiv.org/abs/math/0202004.
The class inherits from Polyhedra, and uses several new methods for root spaces:
RootLatticeRealization
.index_bipartition, returns the bipartition of the indices of the Dynkin diagram vertices, if it is bipartiteRootLatticeRealization
.almost_positive_roots, returns the sorted list of positive and simple negative rootsRootLatticeRealization
.tau_plus_minus, returns two piecewise linear operators on the root space which are used to define the "tropical Coxeter element" in [CFZ]RootLatticeRealization
.almost_positive_root_decomposition, returns the orbit decomposition of the almost positive roots under the dihedral group action of < tau_plus, tau_minus > as defined aboveComponent: combinatorics
Keywords: associahedra
Author: Christian Stump
Reviewer: Frédéric Chapoton, Nicolas M. Thiéry
Merged: sage-5.0.beta8
Issue created by migration from https://trac.sagemath.org/ticket/10817
The text was updated successfully, but these errors were encountered: