Make numpy support SAGE_SPKG_INSTALL_DOCS

[jasongrout]

This ticket implements #10823 for numpy. New spkg at http://sage.math.washington.edu/home/jason/spkg-docs/numpy-1.5.1.p0.spkg (depends on #10792)

Component: packages: standard

Keywords: sd32

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/10826

[sagetrac-drkirkby]

comment:2

See comments on #10828

[jasongrout]

FYI Only---already applied to spkg.

[jasongrout]

comment:3

Attachment: 10826.patch.gz

[sagetrac-drkirkby]

comment:4

See my comments on #10828
I'm not saying this needs work, as it might not do, but if its anything like the matplotlib case, a lot of unnecessary files get copied.

We should clarify this before marking this for review.

Dave

[sagetrac-drkirkby]

Reviewer: David Kirkby

[jasongrout]

comment:6

The numpy docs that are copied contain just the standalone built files, not the full doc source directory.

[sagetrac-drkirkby]

comment:7

I'm surprised there's a data file objects.inv, but overall it looks fine.

Dave

[jasongrout]

comment:8

According to http://sphinx.pocoo.org/ext/intersphinx.html, that file helps Sphinx provide interlinking between documentation. I think you're probably right that it isn't strictly necessary, but I'll bet there is a way to provide interlinking between Sage's, Scipy's, and numpy's documentation if we have that file (as a future project).

[sagetrac-drkirkby]

comment:10

Why is the milestone now a "sage-feature"? Is there any reason it can't go into 4.7, given it has a positive review?

Dave

[jdemeyer]

comment:11

I use sage-feature as a placeholder for tickets with positive review which can't or won't be merged. This ticket depends on #10792 which does not have positive review, so it can't be merged yet. Sorry, I should have mentioned this.

[sagetrac-drkirkby]

comment:12

Replying to @jdemeyer:

I use sage-feature as a placeholder for tickets with positive review which can't or won't be merged. This ticket depends on #10792 which does not have positive review, so it can't be merged yet. Sorry, I should have mentioned this.

If one click' on sage-feature, one gets This is the "big feature" milestone. Tickets assigned here should have somebody responsible for the issue. Once a feature is ready to go in please retag the ticket to the next appropriate milestone and attach a patch/bundle/link to an spkg.

The above description of "sage-feature" does not match the situation on here. Perhaps a new milestone should be created, specifically to address the case of tickets with positive review, but depending on other tickets.

Dave

[jasongrout]

comment:13

Or in the longer term, maybe we should install a trac dependency tracker. For example, something like this:

http://trac-hacks.org/wiki/MasterTicketsPlugin

or this

http://trac-hacks.org/wiki/TracDependencyPlugin

[jdemeyer]

Merged: sage-4.7.alpha2

[jdemeyer]

Changed merged from sage-4.7.alpha2 to none

[jdemeyer]

comment:17

Dan Drake wrote on sage-devel:

Hrm. There is a problem with numpy when SAGE_SPKG_INSTALL_DOCS is set.
Here's the relevant part of the log:

    make[2]: Entering directory `/home/drake/s/sage-4.7.alpha4/spkg/build/numpy-1.5.1.p0/src/doc'
    mkdir -p build
    touch build/generate-stamp
    mkdir -p build/html build/doctrees
    LANG=C sphinx-build -b html -d build/doctrees   source build/html 
    /bin/sh: sphinx-build: not found
    make[2]: *** [html] Error 127
    make[2]: Leaving directory `/home/drake/s/sage-4.7.alpha4/spkg/build/numpy-1.5.1.p0/src/doc'
    Error building numpy docs.

This is a fresh build from source. It looks like we need to alter the
build dependencies to get Sphinx built early. Or perhaps the spkg
installation script could check to see if the INSTALL_DOCS variable is
set, and if so, check that Sphinx is built?

The tricky thing here seems to be that the build deps are different if
SAGE_SPKG_INSTALL_DOCS is set.

I installed the Sphinx spkg and restarted the build, but now I get:

    make[2]: Entering directory `/home/drake/s/sage-4.7.alpha4/spkg/build/numpy-1.5.1.p0/src/doc'
    mkdir -p build
    touch build/generate-stamp
    mkdir -p build/html build/doctrees
    LANG=C sphinx-build -b html -d build/doctrees   source build/html 
    Traceback (most recent call last):
      File "/home/drake/s/sage-4.7.alpha4/local/bin/sphinx-build", line 6, in <module>
        import sage.all
    ImportError: No module named sage.all
    make[2]: *** [html] Error 1
    make[2]: Leaving directory `/home/drake/s/sage-4.7.alpha4/spkg/build/numpy-1.5.1.p0/src/doc'
    Error building numpy docs.

Yikes. Do we need the Sage library before we can build any Sphinx
documents? Do we need to build documents after the usual build process
is done?

[jasongrout]

comment:18

See #11197 for bulding docs after the sage build

[williamstein]

Changed keywords from none to sd32

[mkoeppe]

comment:24

outdated, should close

[mkoeppe]

Changed reviewer from David Kirkby to none

[mkoeppe]

Changed author from Jason Grout to none

[dimpase]

Reviewer: Dima Pasechnik