Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pynac to 0.2.2 #11317

Closed
burcin opened this issue May 9, 2011 · 5 comments
Closed

update pynac to 0.2.2 #11317

burcin opened this issue May 9, 2011 · 5 comments

Comments

@burcin
Copy link

burcin commented May 9, 2011

Here is the long awaited pynac update. It includes patches from upstream (ginac) which fix Sage bugs and should be easy to review.

http://sage.math.washington.edu/home/burcin/pynac/pynac-0.2.2.spkg

This package fixes #9891, #9947 and #8943. Attached patch also adds some more doctests to the Sage library.

I hope this can get reviewed and merged soon. There will be an new release with more substantial changes like #9880.

CC: @jpflori @vbraun @kcrisman

Component: symbolics

Author: Richard Kreckel, Vladimir V. Kisil, Jan Rheinländer, Alexei Sheplyakov, Burcin Erocal

Reviewer: Karl-Dieter Crisman

Merged: sage-4.7.1.alpha1

Issue created by migration from https://trac.sagemath.org/ticket/11317

@burcin burcin added this to the sage-4.7.1 milestone May 9, 2011
@burcin burcin self-assigned this May 9, 2011
@burcin
Copy link
Author

burcin commented May 9, 2011

comment:1

Attachment: trac_11317-conjugate_tests.patch.gz

@kcrisman
Copy link
Member

kcrisman commented May 9, 2011

Reviewer: Karl-Dieter Crisman

@kcrisman
Copy link
Member

kcrisman commented May 9, 2011

comment:2

This is fine too. Notice that there is a typo in the Ginac upstream.


static ex tanh_conjugate(const ex & x)
{
	// conjugate(tan(x))==tan(conjugate(x))
	return tanh(x.conjugate());
}

The method is correct, but the doc says tan, not tanh.


As for the other things, they are nearly all compiler improvements. I'll just check these work on sage.math, but otherwise looks good to go.

@kcrisman
Copy link
Member

kcrisman commented May 9, 2011

comment:3

Good to go. Thank you so much for keeping up with this, Burcin!

@jdemeyer
Copy link

Merged: sage-4.7.1.alpha1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants