MPIR 2.x may fail to build on 32-bit operating systems #11896

ghost · 2011-10-05T02:29:01Z

MPIR fails to build on 32-bit operating systems running on 64-bit processors if CFLAGS contain -m32 and ABI is not set.

The simple solution is to set ABI=32 in this case, which the new spkg now does (on Linux, where the issue occurred). It also sets ABI=64 if the operating system supports it, and ABI isn't already set, and prints according messages.

Upstream report: http://groups.google.com/group/mpir-devel/browse_thread/thread/46ccdc5dfc3485cd

New spkg: http://boxen.math.washington.edu/home/jdemeyer/spkg/mpir-2.1.3.p6.spkg

Upstream: Reported upstream. Little or no feedback.

CC: @nathanncohen @dandrake @strogdon @jdemeyer

Component: packages: standard

Keywords: ABI 64-bit CPU processor Linux -m32 MPN_PATH assembler error bad register lshift

Author: Leif Leonhardy, Jeroen Demeyer

Reviewer: Steven Trogdon, Jeroen Demeyer, Leif Leonhardy

Merged: sage-4.8.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/11896

The text was updated successfully, but these errors were encountered:

nexttime · 2011-10-05T03:12:08Z

Changed reporter from leif to Nathann Cohen, Dan Drake, Steve Trogdon

nexttime · 2011-10-05T03:12:08Z

comment:1

Would be nice if one of you could review this.

For testing, it should be sufficient to (try to) install the spkg with an arbitrary Sage version (of course installed on some 32-bit Linux running on a 64-bit processor):

$ unset ABI # We want to test that the spkg works *without* setting it.
$ env SAGE_CHECK=yes ./sage -i http://sage.math.washington.edu/home/leif/Sage/spkgs/mpir-2.1.3.p5.spkg

After that, you should reinstall the original MPIR spkg from your Sage installation (with ./sage -f spkg/standard/mpir-<version>.spkg) in case you used a Sage version prior to Sage 4.7.2.alpha3 (into which the MPIR 2.1.3.p4 spkg from #8664, the first 2.x version in Sage, was merged).

(No need to uninstall it from Sage 4.7.2.alpha3 or if you happen to have already installed the MPIR 2.1.3.p4 spkg, the GMP-ECM 6.3.p2 spkg and the necessary patches from their tickets.)

You can of course in addition test the spkg on other (64-bit) platforms as well... :-)

Thanks!

nexttime · 2011-10-05T03:18:45Z

Attachment: mpir-2.1.3.p4-p5.diff.gz

Diff between the p4 (from #8664) and the p5 spkg. For reference / review only.

nexttime · 2011-10-05T03:32:26Z

comment:2

P.S.:

I'll rebase the spkgs with newer upstream versions (see #11616) on this one when I find the time. I'll perhaps also provide an MPIR 2.1.4.p0 spkg based on this one which just adds a minor upstream fix (for a rare race condition which leads to an error during the installation).

nexttime · 2011-10-05T03:51:27Z

comment:3

Oh, one more thing:

I cannot test whether the GMP-ECM and MPFR spkgs have the same problem (since they use GMP's / MPIR's CFLAGS), i.e., also fail on such systems if ABI isn't set.

If you find the time, you could also check this by unsetting ABI and reinstalling them (with ./sage -f ...).

strogdon · 2011-10-05T04:53:58Z

Reviewer: Steven Trogdon

strogdon · 2011-10-05T04:53:58Z

comment:5

Replying to @nexttime:

Oh, one more thing: I cannot test whether the GMP-ECM and MPFR spkgs have the same problem (since they use GMP's / MPIR's CFLAGS), i.e., also fail on such systems if ABI isn't set. If you find the time, you could also check this by unsetting ABI and reinstalling them (with ./sage -f ...).

The new mpir spkg installs here on my 32-bit OS with 64-bit processor with ABI unset.

The MPIR test suite passed successfully.
Now cleaning up tmp files.
Making Sage/Python scripts relocatable...
Making script relocatable
Finished installing mpir-2.1.3.p5.spkg

It also installed on an amd64 to which I have access. The ECM and MPFR spkgs reinstalled correctly with ABI unset on both the 32-bit and amd64 machines. A positive review here.

nexttime · 2011-10-05T05:13:20Z

comment:6

Replying to @strogdon:

The new mpir spkg installs here on my 32-bit OS with 64-bit processor with ABI unset.
It also installed on an amd64 to which I have access. The ECM and MPFR spkgs reinstalled correctly with ABI unset on both the 32-bit and amd64 machines. A positive review here.

Speed reviewing, thanks!

nexttime · 2011-10-05T05:13:20Z

Changed reporter from Nathann Cohen, Dan Drake, Steve Trogdon to Nathann Cohen, Dan Drake, Steven Trogdon

nathanncohen · 2011-10-05T10:39:20Z

comment:8

( it compiled perfectly here ! Thank you very much leif ! :-D)

jdemeyer · 2011-10-05T12:18:55Z

Merged: sage-4.7.2.alpha4

jdemeyer · 2011-10-10T07:37:23Z

comment:10

This fails to build on Itanium:

mpir-2.1.3.p5
Machine:
Linux iras 2.6.16.46-0.12-default #1 SMP Thu May 17 14:00:09 UTC 2007 ia64 ia64 ia64 GNU/Linux
Deleting directories from past builds of previous/current versions of mpir-2.1.3.p5
Extracting package /home/buildbot/build/sage/iras-1/iras_full/build/sage-4.7.2.alpha4/spkg/standard/mpir-2.1.3.p5.spkg ...
-rw-r--r-- 1 buildbot sage 3759395 2011-10-04 22:36 /home/buildbot/build/sage/iras-1/iras_full/build/sage-4.7.2.alpha4/spkg/standard/mpir-2.1.3.p5.spkg
Finished extraction
****************************************************
Host system
uname -a:
Linux iras 2.6.16.46-0.12-default #1 SMP Thu May 17 14:00:09 UTC 2007 ia64 ia64 ia64 GNU/Linux
****************************************************
****************************************************
CC Version
gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/local/gcc-4.6.1/ia64-Linux-suse/libexec/gcc/ia64-unknown-linux-gnu/4.6.1/lto-wrapper
Target: ia64-unknown-linux-gnu
Configured with: /usr/local/gcc-4.6.1/src/gcc-4.6.1/configure --enable-languages=c,c++,fortran --with-gnu-as --with-as=/usr/local/binutils-2.21/ia64-Linux-suse-gcc-4.5.1/bin/as --with-gnu-ld --with-ld=/usr/local/binutils-2.21/ia64-Linux-suse-gcc-4.5.1/bin/ld --with-gmp=/usr/local/mpir-2.4.0/ia64-Linux-suse-gcc-4.6.0 --with-mpfr=/usr/local/mpfr-3.0.1/ia64-Linux-suse-mpir-2.4.0-gcc-4.6.0 --with-mpc=/usr/local/mpc-0.9/ia64-Linux-suse-mpir-2.4.0-mpfr-3.0.1-gcc-4.6.0 --prefix=/usr/local/gcc-4.6.1/ia64-Linux-suse
Thread model: posix
gcc version 4.6.1 (GCC) 
****************************************************
Warning: Building MPIR with SAGE_DEBUG=yes disables optimization.
Building a 32-bit version of MPIR
Checking what CFLAGS MPIR would use if they were empty...
Settings required to properly build MPIR, taking into account SAGE_DEBUG etc.:
  CFLAGS:   -g -O0
  LDFLAGS:  -Wl,-z,noexecstack
  ABI:     32
Settings from the "global" environment:
  CC:      gcc
  CFLAGS:  
  (CPPFLAGS, CXX and CXXFLAGS are listed below; these don't get modified.)
Using the spkg's (i.e. Sage's) default (plus mandatory) settings.
Finally using the following settings:
  CC=gcc
  CFLAGS=   -g -O0
  CPPFLAGS=
  CXX=g++
  CXXFLAGS=
  LDFLAGS= -Wl,-z,noexecstack
  ABI=32
(These settings may still get overridden by 'configure' or Makefiles.)
Configuring MPIR with the following options:
    --prefix="/home/buildbot/build/sage/iras-1/iras_full/build/sage-4.7.2.alpha4/local" --enable-shared --enable-static --enable-gmpcompat --enable-cxx=yes 
You can set MPIR_EXTRA_OPTS to pass additional parameters.
checking build system type... ia64-unknown-linux-gnu
checking host system type... ia64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... gawk
checking whether make -j4 sets $(MAKE)... yes
checking whether to enable maintainer-specific portions of Makefiles... no
configure: error: ABI=32 is not among the following valid choices: 64
Error configuring MPIR. (See above for the options passed to it.)

jdemeyer · 2011-10-10T08:13:32Z

comment:11

The problem is that the -m32/-m64 switches are not supported on every system. So we should do the following:

Try building and running with -m64.
Try building and running with -m32.
If both fail, fall back to the old behaviour (which was what?)

jdemeyer · 2011-10-10T08:33:58Z

comment:12

The attached patch should fix the problem. New spkg for testing: http://boxen.math.washington.edu/home/jdemeyer/spkg/mpir-2.1.3.p6.spkg

jdemeyer · 2011-10-10T08:33:58Z

Changed merged from sage-4.7.2.alpha4 to none

nexttime · 2011-10-10T13:00:43Z

comment:15

By the way, I'd say that's a GCC flaw; it should support -m64 on Itanium as well since there it's just a redundant flag, as opposed to a conflicting or unsupported one.

nexttime · 2011-10-10T13:08:10Z

comment:16

Oh, it does have related options for HP-UX: :-)

       -milp32
       -mlp64
           Generate code for a 32-bit or 64-bit environment.  The 32-bit environment sets int,
           long and pointer to 32 bits.  The 64-bit environment sets int to 32 bits and long and
           pointer to 64 bits.  These are HP-UX specific flags.

jdemeyer · 2011-10-10T13:33:40Z

comment:17

Replying to @nexttime:

A much simpler solution is to set CFLAG64="" on ia64 (Itanium), then the first attempt (building and running a 64-bit executable) will succeed.

My patch doesn't do specific checking for Itanium, it will work on any compiler which does not support -m32 and -m64.

nexttime · 2011-10-10T13:42:32Z

comment:18

Replying to @jdemeyer:

Replying to @nexttime:

A much simpler solution is to set CFLAG64="" on ia64 (Itanium), then the first attempt (building and running a 64-bit executable) will succeed.

My patch doesn't do specific checking for Itanium, it will work on any compiler which does not support -m32 and -m64.

I'd factor out -m32 though, i.e., use $CFLAG32 in the second attempt and add

if [[ -z $CFLAG32 ]]; then
    CFLAG32=-m32
fi

or

: ${CFLAG32=-m32} # doesn't invalidate an empty setting ("")

or the like (at the top level), such that porting people can adapt it to whatever they need.

nexttime · 2011-10-10T13:45:01Z

comment:19

Alternatively, you could just set ABI=64 (without any checks) on Itanium, which is reasonable as it doesn't (or at least we don't) support anything else on that.

nexttime · 2011-10-10T13:47:13Z

comment:20

(I originally intended to restrict the test / setting the ABI to x86 / x86_64 and ppc / ppc64 anyway... ;-) )

jdemeyer · 2011-10-11T15:41:03Z

comment:22

New spkg which uses $CFLAG32, same location. Needs review.

nexttime · 2011-10-11T16:30:26Z

comment:23

Replying to @jdemeyer:

New spkg which uses $CFLAG32, same location. Needs review.

Positive review, although the comment

            # (Usually succeeds, unless e.g. a 32-bit CPU is explicitly selected by CFLAGS.)

referred to building, not running a 64-bit executable, and the Changelog entry mentions -m32 and -m64 rather than CFLAG32 and CFLAG64.

Tested with SAGE_CHECK=yes on Linux x86, x86_64 and ia64, with and without {C,CPP,CXX}FLAGS and ABI set.

nexttime · 2011-10-11T16:30:26Z

Changed author from Leif Leonhardy to Leif Leonhardy, Jeroen Demeyer

nexttime · 2011-10-11T16:30:26Z

Changed reviewer from Steven Trogdon to Steven Trogdon, Jeroen Demeyer, Leif Leonhardy

jdemeyer · 2011-10-11T19:20:20Z

comment:24

Attachment: mpir-2.1.3.p5-p6.diff.gz

Replying to @nexttime:

Replying to @jdemeyer:

New spkg which uses $CFLAG32, same location. Needs review.

Positive review, although the comment
            # (Usually succeeds, unless e.g. a 32-bit CPU is explicitly selected by CFLAGS.)
referred to building, not running a 64-bit executable

I think it is actually more correct to refer to building and running rather than just building.

the Changelog entry mentions -m32 and -m64 rather than CFLAG32 and CFLAG64.

Fixed this.

jdemeyer · 2011-10-14T09:40:56Z

Merged: sage-4.7.3.alpha0

jhpalmieri · 2011-10-29T18:16:53Z

comment:26

For what it's worth, this fails to build on the skynet machine silius. I get the same error message with p5 and p6:

Building a 64-bit version of MPIR
Checking what CFLAGS MPIR would use if they were empty...
Settings required to properly build MPIR, taking into account SAGE_DEBUG etc.:
  CFLAGS:
  LDFLAGS:  -Wl,-z,noexecstack
  ABI:     64
Settings from the "global" environment:
  CC:      gcc
  CFLAGS:
  (CPPFLAGS, CXX and CXXFLAGS are listed below; these don't get modified.)
Using the spkg's (i.e. Sage's) default (plus mandatory) settings.
Finally using the following settings:
  CC=gcc
  CFLAGS=  -g -O3
  CPPFLAGS=
  CXX=g++
  CXXFLAGS=
  LDFLAGS= -Wl,-z,noexecstack
  ABI=64
(These settings may still get overridden by 'configure' or Makefiles.)
Configuring MPIR with the following options:
    --prefix="/home/palmieri/silius/sage-4.7.2.alpha4/local" --enable-shared --enable-static --ena\
ble-gmpcompat --enable-cxx=yes
You can set MPIR_EXTRA_OPTS to pass additional parameters.
checking build system type... power7-unknown-linux-gnu
checking host system type... power7-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... gawk
checking whether make -j12 sets $(MAKE)... yes
checking whether to enable maintainer-specific portions of Makefiles... no
configure: error: ABI=64 is not among the following valid choices: mode64 mode32 32
Error configuring MPIR. (See above for the options passed to it.)

nexttime · 2011-10-29T20:24:10Z

comment:27

Replying to @jhpalmieri:

For what it's worth, this fails to build on the skynet machine silius. I get the same error message with p5 and p6.

Ooops, I was pretty sure I also tested it there. The p4 builds just fine.

I'll prepare a follow-up spkg...

nexttime · 2011-10-31T00:41:43Z

comment:28

Replying to @nexttime:

Replying to @jhpalmieri:

For what it's worth, this fails to build on the skynet machine silius. I get the same error message with p5 and p6.

Ooops, I was pretty sure I also tested it there. The p4 builds just fine.

I'll prepare a follow-up spkg...

New spkg (p7) up on #11964, needs review.

jdemeyer · 2011-11-03T16:14:43Z

Milestone sage-4.7.3 deleted

jdemeyer · 2011-11-03T16:18:41Z

Changed merged from sage-4.7.3.alpha0 to sage-4.8.alpha0

nexttime mannequin added this to the sage-4.7.2 milestone Oct 5, 2011

nexttime mannequin added c: packages: standard labels Oct 5, 2011

nexttime mannequin self-assigned this Oct 5, 2011

This comment has been minimized.

Sign in to view

nexttime mannequin added the s: needs review label Oct 5, 2011

This comment has been minimized.

Sign in to view

strogdon added s: positive review and removed s: needs review labels Oct 5, 2011

jdemeyer removed the s: positive review label Oct 5, 2011

jdemeyer closed this as completed Oct 5, 2011

jdemeyer reopened this Oct 10, 2011

This comment has been minimized.

Sign in to view

jdemeyer modified the milestones: sage-4.7.2, sage-4.8 Oct 11, 2011

jdemeyer added p: critical / 2 and removed p: blocker / 1 labels Oct 11, 2011

jdemeyer added the s: needs review label Oct 11, 2011

nexttime mannequin added s: positive review and removed s: needs review labels Oct 11, 2011

jdemeyer removed the s: positive review label Oct 14, 2011

jdemeyer closed this as completed Oct 14, 2011

jdemeyer removed this from the sage-4.8 milestone Nov 3, 2011

jdemeyer added this to the sage-4.8 milestone Nov 3, 2011

williamstein mentioned this issue Dec 3, 2011

Upgrade Sage's MPIR spkg to version 2.1.3 #8664

Closed

nexttime mannequin mentioned this issue Oct 31, 2011

MPIR: Use proper ABI name on Linux PPC64 #11964

Closed

MPIR 2.x may fail to build on 32-bit operating systems #11896

MPIR 2.x may fail to build on 32-bit operating systems #11896

Comments

ghost commented Oct 5, 2011

nexttime mannequin commented Oct 5, 2011

nexttime mannequin commented Oct 5, 2011

This comment has been minimized.

nexttime mannequin commented Oct 5, 2011

nexttime mannequin commented Oct 5, 2011

nexttime mannequin commented Oct 5, 2011

This comment has been minimized.

strogdon commented Oct 5, 2011

strogdon commented Oct 5, 2011

This comment has been minimized.

nexttime mannequin commented Oct 5, 2011

nexttime mannequin commented Oct 5, 2011

nathanncohen mannequin commented Oct 5, 2011

jdemeyer commented Oct 5, 2011

jdemeyer commented Oct 10, 2011

jdemeyer commented Oct 10, 2011

This comment has been minimized.

jdemeyer commented Oct 10, 2011

jdemeyer commented Oct 10, 2011

nexttime mannequin commented Oct 10, 2011

nexttime mannequin commented Oct 10, 2011

jdemeyer commented Oct 10, 2011

nexttime mannequin commented Oct 10, 2011

nexttime mannequin commented Oct 10, 2011

nexttime mannequin commented Oct 10, 2011

jdemeyer commented Oct 11, 2011

nexttime mannequin commented Oct 11, 2011

nexttime mannequin commented Oct 11, 2011

nexttime mannequin commented Oct 11, 2011

jdemeyer commented Oct 11, 2011

jdemeyer commented Oct 14, 2011

jhpalmieri commented Oct 29, 2011

nexttime mannequin commented Oct 29, 2011

nexttime mannequin commented Oct 31, 2011

jdemeyer commented Nov 3, 2011

jdemeyer commented Nov 3, 2011