Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some tests for the Qhull optional package #12352

Closed
sagetrac-mhampton mannequin opened this issue Jan 25, 2012 · 11 comments
Closed

Add some tests for the Qhull optional package #12352

sagetrac-mhampton mannequin opened this issue Jan 25, 2012 · 11 comments

Comments

@sagetrac-mhampton
Copy link
Mannequin

sagetrac-mhampton mannequin commented Jan 25, 2012

At our dear leader's request I am adding a test file for the Qhull optional package.

This will be quite minimal, since what I'd really like is to add a Qhull backend for the Polyhedron class, which would come with its own tests.

If anyone is interested in adding more elaborate tests it wouldn't be very hard since the documentation at the Qhull site is pretty good.

CC: @videlec

Component: packages: optional

Keywords: Qhull, polyhedra, polyhedron

Author: Frédéric Chapoton

Branch/Commit: public/ticket/12352 @ 547c508

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/12352

@sagetrac-mhampton sagetrac-mhampton mannequin added this to the sage-5.11 milestone Jan 25, 2012
@sagetrac-mhampton
Copy link
Mannequin Author

sagetrac-mhampton mannequin commented Jan 25, 2012

Attachment: trac_12352_Qhull_optional_package_testfile.patch.gz

adds a minimal test for the Qhull optional package

@loefflerd
Copy link
Mannequin

loefflerd mannequin commented Mar 12, 2012

comment:2

The tests need to be marked with "# optional qhull" or something, since otherwise they fail when this optional package isn't installed.

@loefflerd loefflerd mannequin added s: needs work and removed s: needs review labels Mar 12, 2012
@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014
@fchapoton
Copy link
Contributor

Branch: public/ticket/12352

@fchapoton
Copy link
Contributor

New commits:

24a3059trac #12352: adding some tests for the Qhull optional package
547c508trac #12352 refreshed

@fchapoton
Copy link
Contributor

Commit: 547c508

@jdemeyer
Copy link

jdemeyer commented Apr 9, 2015

comment:8

Since this is just tests and nothing else, why not add this to a spkg-check file inside the qhull package?

@videlec
Copy link
Contributor

videlec commented Aug 16, 2015

comment:9

Replying to @jdemeyer:

Since this is just tests and nothing else, why not add this to a spkg-check file inside the qhull package?

+1. There is no interface being tested or so.

Doesn't qhull have a testsuite?

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 3, 2016

comment:10

Marking this as "wontfix". The spkg-check of the qhull package (#21143) seems enough.

@mkoeppe mkoeppe removed this from the sage-6.4 milestone Aug 3, 2016
@fchapoton
Copy link
Contributor

Changed author from Marshall Hampton to Frédéric Chapoton

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@embray
Copy link
Contributor

embray commented Aug 30, 2016

comment:12

Determined to be invalid/duplicate/wontfix (closing as "wontfix" as a catch-all resolution).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants