-
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some tests for the Qhull optional package #12352
Comments
Attachment: trac_12352_Qhull_optional_package_testfile.patch.gz adds a minimal test for the Qhull optional package |
comment:2
The tests need to be marked with "# optional qhull" or something, since otherwise they fail when this optional package isn't installed. |
Branch: public/ticket/12352 |
Commit: |
comment:8
Since this is just tests and nothing else, why not add this to a |
comment:9
Replying to @jdemeyer:
+1. There is no interface being tested or so. Doesn't |
comment:10
Marking this as "wontfix". The spkg-check of the qhull package (#21143) seems enough. |
Changed author from Marshall Hampton to Frédéric Chapoton |
Reviewer: Frédéric Chapoton |
comment:12
Determined to be invalid/duplicate/wontfix (closing as "wontfix" as a catch-all resolution). |
At our dear leader's request I am adding a test file for the Qhull optional package.
This will be quite minimal, since what I'd really like is to add a Qhull backend for the Polyhedron class, which would come with its own tests.
If anyone is interested in adding more elaborate tests it wouldn't be very hard since the documentation at the Qhull site is pretty good.
CC: @videlec
Component: packages: optional
Keywords: Qhull, polyhedra, polyhedron
Author: Frédéric Chapoton
Branch/Commit: public/ticket/12352 @
547c508
Reviewer: Frédéric Chapoton
Issue created by migration from https://trac.sagemath.org/ticket/12352
The text was updated successfully, but these errors were encountered: