Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make palp respect global CC flag #12431

Closed
ohanar opened this issue Feb 4, 2012 · 8 comments
Closed

make palp respect global CC flag #12431

ohanar opened this issue Feb 4, 2012 · 8 comments

Comments

@ohanar
Copy link
Member

ohanar commented Feb 4, 2012

The palp spkg currently does not respect the global CC flag, we should fix this (for instance for #12426).

Fixed by #7071.

CC: @jdemeyer

Component: build

Reviewer: R. Andrew Ohana

Issue created by migration from https://trac.sagemath.org/ticket/12431

@ohanar
Copy link
Member Author

ohanar commented Feb 4, 2012

for review purposes

@ohanar
Copy link
Member Author

ohanar commented Feb 4, 2012

comment:1

Attachment: palp-1.1.p4.patch.gz

@ohanar
Copy link
Member Author

ohanar commented Feb 9, 2012

comment:2

please mark as duplicate of #7071

@jdemeyer
Copy link

jdemeyer commented Feb 9, 2012

comment:3

I guess changing the milestone and setting positive_review, you can do yourself, right?

@jdemeyer
Copy link

jdemeyer commented Feb 9, 2012

Reviewer: R. Andrew Ohana

@jdemeyer jdemeyer removed this from the sage-5.0 milestone Feb 9, 2012
@ohanar
Copy link
Member Author

ohanar commented Feb 9, 2012

comment:4

Replying to @jdemeyer:

I guess changing the milestone and setting positive_review, you can do yourself, right?

Yes I can, I thought that duplicate was a release manager only status, not a milestone, oops :p.

@jdemeyer
Copy link

jdemeyer commented Feb 9, 2012

comment:5

The difference is between proposing the ticket as duplicate and actually closing it as duplicate.

@jdemeyer

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants