OS X Lion: don't require setting SAGE_PORT

[jhpalmieri]

The prereq script requires setting SAGE_PORT to build on OS X Lion. We should remove this requirement, since building successfully on Lion should be imminent.

Apply attachment: trac_12576-lion-sage_port.patch to the root repo.

Depends on #4949
Depends on #12112

Component: build

Keywords: osx lion prereq

Author: John Palmieri

Reviewer: Jeroen Demeyer

Merged: sage-5.0.beta13

Issue created by migration from https://trac.sagemath.org/ticket/12576

[jdemeyer]

comment:2

While you're changing this, you should really also fix the xcodebuild check. At least, redirect 2>/dev/null so we don't see the error messages.

[jhpalmieri]

comment:3

With the current patch, xcodebuild is only used on pre-Lion systems. Since whoever worked on prereq before seemed to think that the particular version of Xcode was important in some cases, I think we should keep this check there. I can redirect the output, though.

[jdemeyer]

comment:5

Please remove also

echo "Solaris 9: copying work around stdint.h" 
cp $SAGE_ROOT/spkg/base/stdint.h_Solaris9 $SAGE_LOCAL/include/stdint.h 

(the file $SAGE_ROOT/spkg/base/stdint.h_Solaris9 was removed in #11073).

[jdemeyer]

Dependencies: #4949

[jdemeyer]

comment:7

In fact, why not remove all of

if [ "$UNAME" = "SunOS" ] && [ "$RELEASE" = "5.9" ]; then
    echo "WARNING: Building Sage is not supported on Solaris 9"
    echo "but it might work, so the build will continue."
    echo "Solaris 9: copying work around stdint.h"
    cp $SAGE_ROOT/spkg/base/stdint.h_Solaris9 $SAGE_LOCAL/include/stdint.h
fi

if [ "$UNAME" = "SunOS" ] && [ "$RELEASE" = "5.8" ]; then
    echo "WARNING: Building Sage is not supported on Solaris 8"
    echo "but it might work, so the build will continue."
    echo "Solaris 8: copying work around stdint.h"
    cp $SAGE_ROOT/spkg/base/stdint.h_Solaris9 $SAGE_LOCAL/include/stdint.h
fi

as those versions are already checked for above.

[jdemeyer]

comment:8

I would also remove

# From Kate Minola kate01123@gmail.com
# On my powerpc-Darwin machine with csh as my shell, when I attempt
# to build SAGE in the background (i.e., "make &") the build
# stops when executing 'prereq-0.2-install'.  The reason is
# that the line
#     which $1 > /dev/null
# issues a SIGTTOU signal (background process attempting to write
# to tty).  Solution:
trap '' TTOU

which refers to a very outdated version of Sage (and I doubt this one line will fix the problem described).

[jdemeyer]

comment:9

Replace

XCODE_VERS=`xcodebuild -version | grep Xcode | sed -e 's/[A-Za-z ]//g' 2> /dev/null

by

XCODE_VERS=`xcodebuild -version 2>/dev/null | grep Xcode | sed 's/[A-Za-z ]//g'

[jdemeyer]

comment:10

Replace TABs by spaces.

[jdemeyer]

comment:11

I would also replace

echo "You are using Xcode version " $XCODE_VERS "."

by

echo "You are using Xcode version $XCODE_VERS."

which is more readable.

[jdemeyer]

comment:12

This "if" will never be true (as you already special-cased it above), so this block can be removed:

        if [ $DARWIN_VERSION -gt 10 ]; then
           echo "Probably you need Xcode 4.3 (or later)"
           echo "Also, make sure you install Xcode's"
           echo "Command Line Tools -- see Sage's README.txt."

[jhpalmieri]

comment:13

Fixed. Here's a new patch.

[jdemeyer]

Reviewer: Jeroen Demeyer

[jdemeyer]

Changed dependencies from #4949 to #4949, #11881

[jdemeyer]

comment:16

Undid the changes to spkg/base/bzip2-1.0.5-install (for compatibility with #12102)

[jdemeyer]

comment:17

The parts of this patch which are unrelated to Darwin are moved to #12112.

[jdemeyer]

Changed dependencies from #4949, #11881 to #4949, #11881, #12112

[jdemeyer]

Attachment: trac_12576-lion-sage_port.patch.gz

root repo

[jdemeyer]

Changed dependencies from #4949, #11881, #12112 to #4949, #12112

[jdemeyer]

Merged: sage-5.0.beta13