Deprecate is_* functions.

[sagetrac-JStarx]

As discussed here: http://groups.google.com/group/sage-devel/browse_thread/thread/e8c2470e270f616b/c760f4a79d28f467?lnk=gst&q=is_#, functions of the form is_SomeName(x) should be deprecated.

This patch removes 106 of them and replaces them with calls to isinstance. The patch was created by running the attached python script. It searches through the source for functions of the form

def is_SomeName(x):
    """a docstring"""
    return isinstance(x, SomeName)

where SomeName is the class of a Sage object, deletes them, and replaces any calls with calls to isinstance. After the script ran I made sure sage built, passed all its tests, and I looked through the diff to make sure nothing silly happened.

CC: @nilesjohnson

Component: misc

Keywords: is_functions

Work Issues: split patch, docs do not build

Branch/Commit: u/rws/delete_some_of_the_depreciated_is___functions_ @ 4236760

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/12824

[sagetrac-JStarx]

comment:1

Attachment: remove_is.py.gz

[sagetrac-JStarx]

Attachment: trac12824.patch.gz

[a-andre]

Work Issues: rebase

[a-andre]

comment:5

Please rebase your patch.

[rwst]

Branch: u/rws/delete_some_of_the_depreciated_is___functions_

[rwst]

comment:11

Most hunks in this monster patch are either already applied or are failing, so I'm uploading what's left. However, docs do not build with this, something is seriously wrong.

---

New commits:

4236760

12824: Delete some deprecated is_* functions

[rwst]

Changed work issues from rebase to docs do not build

[rwst]

Commit: 4236760

[rwst]

Changed work issues from docs do not build to split patch, docs do not build

[rwst]

comment:12

This should be split up, at least in a rings/, a modular/ and a ticket for the rest.

[jdemeyer]

comment:13

You cannot just remove functions without deprecation first.

[jdemeyer]

comment:14

I think the split up should done in a different way:

1. stop using is_* functions in doctests.
2. stop using is_* functions in the Sage library.
3. deprecate is_* functions.

[mkoeppe]

comment:16

superseded by Meta-ticket #32414

[mkoeppe]

Changed author from Jim Stark to none

[dimpase]

Reviewer: Dima Pasechnik