Pass -no-undefined flag to autotool based spkg

[jpflori]

A bunch of spkg using autotools do not build shared libraries of Cygwin because -no-undefined flag is not passed to libtool:

• cddlib (update in Upgrade and clean up cddlib #13026, we ship a lot of patches for that one, so if I report upstream for that particular issue, what for the others? opened Let cddlib build a shared lib on Cygwin. #15872),
• eclib (fixed in eclib does not build on Cygwin #13325 with new upstream version),
• ecm (fixed upstream, see https://gforge.inria.fr/scm/viewvc.php?view=rev&root=ecm&revision=2304),
• givaro (updated in Upgrade Givaro to version 3.7.0 #9511 and Update Givaro to 3.7.1 #13164, try http://www.infres.enst.fr/~flori/sage/givaro-3.7.1.p0.spkg, reported upstream, got in, see https://forge.imag.fr/scm/browser.php?group_id=187),
• glpk (updated in Update GLPK to 4.55 #12703, reported upstream, some feedback then nothing, see http://lists.gnu.org/archive/html/help-glpk/2012-12/msg00008.html, my last answer does not appear (although it was sent to marco and the list which must be somehow filtered), new discussion at http://lists.gnu.org/archive/html/help-glpk/2014-11/msg00000.html),
• gsl (mentions of -no-undefined in src code but only for MinGW, reported upstream at https://savannah.gnu.org/bugs/index.php?37894, you can try http://boxen.math.washington.edu/home/jpflori/gsl-1.15.p1.spkg, this is Let GSL build a shared library on Cygwin #14096, bumped upstream one year later, fixed upstream: http://git.savannah.gnu.org/cgit/gsl.git/commit/?id=1d002ee931b6a19333416ba8c4c4cccbc009b6a9),
• iml (updated in update iml to the 1.0.3 release + our patches #748, try non updated at http://www.infres.enst.fr/~flori/sage/iml-1.0.1.p15.spkg, not sure upstream still exists, opened Let IML build a shared library on Cygwin #15839, actually fixed upstream with 1.0.4 update, see Python 3 preparation: Py3 has no more the special object-function "__nonzero__" #16076),
• libfplll (see libfplll fails to build in parallel on Cygwin #13804 for a quick (different problem) fix and upgrade fpLLL to version 4.0.4 #12835 for the fact we ship a really old version, should update it before thinking about the problem here, fixed in new upstream version 4.0.3),
• linbox (updated in Update LinBox to most recent upstream release #12883, try http://www.infres.enst.fr/~flori/sage/linbox-1.3.2.p0.spkg, reported upstream, fixed, see https://groups.google.com/d/topic/linbox-devel/sHan2BB8HVM/discussion),
• lrcalc (fixed in Let lrcalc build as a shared library on Cygwin. #13839 which should be half upstream),
• mpfi (fixed upstream, see https://gforge.inria.fr/scm/viewvc.php?view=rev&root=mpfi&revision=656),
• ntl (broken and fixed in Ensure that libraries link to the shared version of NTL by default #11635, no real upstream anymore as far as I understand, in fact Shoup is working on NTL again and I've made him aware of that),
• libgap (guess we are more or less upstream, see Let libgap build a shared library on Cygwin #14038)
• gf2x (fixed in Let gf2x build a shared library on Cygwin #15014, reported upstream, I'll provide a proper fix when I have time)

Upstream: None of the above - read trac for reasoning.

CC: @kcrisman @dimpase

Component: porting: Cygwin

Keywords: spkg shared library

Reviewer: Jean-Pierre Flori

Issue created by migration from https://trac.sagemath.org/ticket/13354

[jpflori]

comment:2

Updates for

• cddlib in Upgrade and clean up cddlib #13026,
• eclib in eclib does not build on Cygwin #13325,
• ecm,
• givaro in Upgrade Givaro to version 3.7.0 #9511, Update Givaro to 3.7.1 #13164,
• glpk in Update GLPK to 4.55 #12703,
• gsl,
• iml in update iml to the 1.0.3 release + our patches #748,
• libfplll,
• linbox in Update LinBox to most recent upstream release #12883,
• lrcalc,
• mpfi,
• ntl in Ensure that libraries link to the shared version of NTL by default #11635.

[jpflori]

comment:5

For the updated fixed linbox, you'll need first iml, and then updated fixed givaro together with dependencies at #12840 and #12841.

[jpflori]

comment:6

Wrong button...

[jpflori]

comment:7

The Linbox spkg from #12883 changed, so the one linked here is now outdated.

[jpflori]

comment:8

The linbox spkg is now rebased on top of #12883, but nothing is committed.
By the way, the spkg there lacks an hg tag.

[jpflori]

Attachment: linbox-1.3.2.p0.diff.gz

Spkg diff, for review only.

[jpflori]

comment:12

Reported upstream for givaro, mpfi, linbox, gsl.

[jpflori]

comment:13

Reported for glpk and libfplll as well.

[jpflori]

comment:14

Contacted upstream ecm as well.

[jpflori]

comment:15

Reported for lrcalc as well.

[jpflori]

comment:16

MPFI is fixed upstream, see:
https://gforge.inria.fr/scm/viewvc.php?view=rev&root=mpfi&revision=656

Givaro is fixed upstream:
https://forge.imag.fr/scm/browser.php?group_id=187

I'm working on lrcalc as now Sage is more or less upstream.
(I guess IML will be the same.)

And I'll provide quickly a patch for upstream ECM and it should get merged.

Feedback from fplll which I guess will be fixed in a couple of weeks in the new version (so we'll have to update to get a shared library).

Feedback from GSL and GLPK as well.

No feedback from LinBox yet.

[jpflori]

comment:17

I've open a ticket for lrcalc, see #13839.
Spkg coming soon.

[jpflori]

comment:18

ECM is fixed upstream.
See
https://gforge.inria.fr/scm/viewvc.php?view=rev&root=ecm&revision=2304

[kcrisman]

comment:19

JP, if you could be sure to somehow indicate on tickets you open for this that this is the metaticket for them?

[jpflori]

comment:20

Replying to @kcrisman:

JP, if you could be sure to somehow indicate on tickets you open for this that this is the metaticket for them?

I'll try :)

[jpflori]

comment:21

Libgap needs fixing as well.

[jpflori]

comment:29

#15014 is for gf2x, this prevents building NTL on Cygwin...

[jpflori]

comment:31

For the record, the spkg needing patches are as far as I know:

• iml
• glpk
• cddlib

[jpflori]

comment:33

Opened #15839 for IML.

[jpflori]

comment:34

GSL has been fixed upstream!
http://git.savannah.gnu.org/cgit/gsl.git/commit/?id=1d002ee931b6a19333416ba8c4c4cccbc009b6a9

[jpflori]

comment:35

Opened #15872 for cddlib.

[jpflori]

comment:39

All packages we currently ship are ok upstream or configured or patched by us.

[jpflori]

Reviewer: Jean-Pierre Flori