Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of symmetric function code #14220

Closed
zabrocki mannequin opened this issue Mar 3, 2013 · 15 comments
Closed

Cleanup of symmetric function code #14220

zabrocki mannequin opened this issue Mar 3, 2013 · 15 comments

Comments

@zabrocki
Copy link
Mannequin

zabrocki mannequin commented Mar 3, 2013

Recent tickets which changed the symmetric function code (potentially #5457, #13399, #13404, #13762, but maybe others) included unnecessary import statements and lines that raise warnings with pyflakes. This ticket corrects most of these warnings plus minor cleanup of the symmetric function code.

This sort of cleanup in new_kschur.py and k_dual.py is done in #13743, #14235, #14237

Apply:

Depends on #13605

CC: @anneschilling @saliola @sagetrac-chrisjamesberg

Component: combinatorics

Keywords: symmetric functions, pyflakes

Author: Mike Zabrocki

Reviewer: Frédéric Chapoton

Merged: sage-5.9.beta4

Issue created by migration from https://trac.sagemath.org/ticket/14220

@zabrocki zabrocki mannequin added this to the sage-5.9 milestone Mar 3, 2013
@zabrocki zabrocki mannequin added c: combinatorics labels Mar 3, 2013
@zabrocki zabrocki mannequin self-assigned this Mar 3, 2013
@zabrocki

This comment has been minimized.

@zabrocki
Copy link
Mannequin Author

zabrocki mannequin commented Mar 12, 2013

Changed author from zabrocki to Mike Zabrocki

@zabrocki
Copy link
Mannequin Author

zabrocki mannequin commented Mar 12, 2013

comment:3

Attachment: trac_14220_symmetric_function_cleanup-mz.patch.gz

@zabrocki zabrocki mannequin added the s: needs review label Mar 12, 2013
@zabrocki

This comment has been minimized.

@fchapoton
Copy link
Contributor

comment:5

I have added a tiny patch, trying to ensure that all tests pass in ncsf

If the bot turns green, I will give a positive review

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:6

positive review

@zabrocki
Copy link
Mannequin Author

zabrocki mannequin commented Mar 17, 2013

comment:7

Thanks for the review and for catching the ncsf cleanup.

@jdemeyer
Copy link

comment:8

This needs to be rebased to sage-5.9.beta0.

@zabrocki
Copy link
Mannequin Author

zabrocki mannequin commented Mar 19, 2013

Attachment: trac_14220_sym_clean-fc.2.patch.gz

@zabrocki

This comment has been minimized.

@zabrocki zabrocki mannequin added s: needs review and removed s: needs work labels Mar 19, 2013
@tscrim
Copy link
Collaborator

tscrim commented Apr 1, 2013

comment:10

This applied cleanly for me so I'm setting this back to positive review.

@zabrocki
Copy link
Mannequin Author

zabrocki mannequin commented Apr 1, 2013

comment:11

Hi Travis. Thanks for coming back to this one.

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link

jdemeyer commented Apr 6, 2013

Merged: sage-5.9.beta4

@jdemeyer jdemeyer closed this as completed Apr 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants