improve dynamic attributes of symbolic expressions

[burcin]

Symbolic functions can define dynamic attributes that will be added to symbolic expressions representing evaluated forms of these functions (#9556).

This patch extends the existing functionality to allow these attributes to take arbitrary arguments. It also passes the function class and the symbolic expression as arguments.

Apply: attachment: trac_14802-dynamic_attribute_args.patch

Depends on #14780

CC: @vbraun @eviatarbach

Component: symbolics

Keywords: sd48

Author: Burcin Erocal

Branch/Commit: 5c579d8

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/14802

[burcin]

Dependencies: #14780

[vbraun]

comment:4

I'm getting doctest failures:

sage -t sage/symbolic/function_factory.py  # 1 doctest failed
sage -t sage/symbolic/expression.pyx  # 3 doctests failed

Missing dependency?

[burcin]

comment:5

Attachment: trac_14802-dynamic_attribute_args.patch.gz

Replying to @vbraun:

I'm getting doctest failures:

sage -t sage/symbolic/function_factory.py  # 1 doctest failed
sage -t sage/symbolic/expression.pyx  # 3 doctests failed

Missing dependency?

I forgot to update the documentation after adding the new function class argument. Updated patch attached.

[vbraun]

comment:6

looks good to me

[vbraun]

Reviewer: Volker Braun

[vbraun]

Branch: u/vbraun/improve_dynamic_attributes_of_symbolic_expressions

[vbraun]

comment:10

Merge conflict with sage-6.2.beta6 will have to be resolved

---

New commits:

a6bea64

Import of trac_14802-dynamic_attribute_args.patch from

[vbraun]

Commit: a6bea64

[rwst]

Changed branch from u/vbraun/improve_dynamic_attributes_of_symbolic_expressions to public/14802

[rwst]

Changed commit from a6bea64 to 80851f6

[rwst]

comment:12

rebased on 6.2.beta6

---

New commits:

80851f6

Merge branch 'u/vbraun/improve_dynamic_attributes_of_symbolic_expressions' of ssh://trac.sagemath.org/sage into ticket/14802

[rwst]

comment:13

rebased on 6.2.beta7

---

New commits:

32e801a

Import of trac_14802-dynamic_attribute_args.patch from

[rwst]

Changed branch from public/14802 to public/14802-1

[rwst]

Changed commit from 80851f6 to 32e801a

[vbraun]

comment:15

Tabs are not allowed, can you convert it to spaces?

sage -t --long src/sage/symbolic/pynac.pyx  # Tab character found

[sagetrac-git]

Changed commit from 32e801a to 5c579d8

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

5c579d8

14802: remove tabs

[vbraun]

Changed branch from public/14802-1 to 5c579d8