Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Mutability class ready to be used #15264

Open
dkrenn opened this issue Oct 9, 2013 · 0 comments
Open

make Mutability class ready to be used #15264

dkrenn opened this issue Oct 9, 2013 · 0 comments

Comments

@dkrenn
Copy link
Contributor

dkrenn commented Oct 9, 2013

Looking at the code in sage/structure/mutability.pyx, one notices some things that should be changed:

Update the methods in Mutability: The corresponding methods in sage/structure/sequence.py seem to work nicely. E.g. there self._is_immutable = 1 (in set_immutable) was changed to self._is_immutable = True or self._is_immutable got a return and a try-except (in is_immutable))

Add a doctest in require_mutable and require_immutable that uses the class Mutability.

Add doctests to set_immutable and to is_immutable that really test the code (and note just test the code in sage/structure/sequence.py.

Add doctests to all functions.

Maybe: combine _require_mutable and _require_mutable_cdef with cpdef.

See also the discussion "Mutability" on sage-devel https://groups.google.com/forum/#!topic/sage-devel/dnXSgh56Boo

Component: misc

Keywords: mutability doctests

Issue created by migration from https://trac.sagemath.org/ticket/15264

@dkrenn dkrenn added this to the sage-6.1 milestone Oct 9, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014
@mkoeppe mkoeppe removed this from the sage-6.4 milestone Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants