-
-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
directed immutable graphs report twice too many edges #15491
Comments
Branch: u/ncohen/15491 |
Commit: |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:3
For a review, I need some information on
Also there is trailing whitespace in error messages:
And I think the French rules of typography shouldn't be used in an English text. Hence, replace |
comment:4
Sorry, I just notice that
becomes
So, no trailing whitespace. |
comment:5
Yo !
Okay. Just to make things clear, I don't like this function, it was just part of the
I removed the
Done.
Which trailing whitespace ?
There is no occurrence of " : " in this file, and to be honest I could not care less about the spaces between and after the ":". I am french, and most of the books I read are english. I don't care whether there is a " : " or ": ", I don't even notice the difference. My problem with spaces before/after ":" is that there are grammar nazis on both sides : the english complain when I put spaces, the french when I don't. Honestly do whatever you want with that. Though there again, I couldn't find any occurrence of " : " in that file. Nathann |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:7
Replying to @nathanncohen:
I don't like it either, but I do like if equal graphs evaluate equal.
Aha, I see. Pointers are mind bending.
Yes, I have not been aware that Python lets you do those things. I thought that
is a syntax error, but it results in 'hello'.
Good idea.
There is one in the doc string that I cited.
I don't like imposing rules of one language to another language. There are stories of Germans named, e.g., "Müller", having problems with US cops, because the cops wouldn't even notice that there are dots over the "u" in the guy's passport, and would certainly not accept that the correct way to spell this German name on a keyboard without Umlaut is "Mueller" and not "Muller". Actually I hate myself for writing "Groebner" instead of "Gröbner" in Sage doc strings (but at least I don't write "Grobner"). Of course, errors can occur, specifically when writing text in a foreign language, and an extra space certainly is not a big drama (I am not calling you an imperialist : |
comment:8
Yooooooooooo !!
I can't say I like that equal graphs evaluate equal, but I certainly grew used to it.
They are.
Oh. Right.
Yeah. In Sage we respect freedom and everything, but accents are off limits
And when we will be done with the spaces before ":" the hunt for american vs english spellings will begin
Good. Cause I just washed my hair and I have a towel on my head right now. And you can't seriously call "imperialist" somebody who has a (pink) towel on his head. Really, you can't. It would sound ridiculous.
Ahahahah. Okay, as you prefer ! Nathann |
comment:9
Replying to @nathanncohen:
Indeed. I much prefer "neighbours" over "neighbors" and "centre" over "center"...
|
Reviewer: Simon King |
comment:10
The added tests show that the bug is fixed. The added comment clarifies a few things. All tests pass. And there will be "space" (or rather : "space removal") for anti-imperialism on different tickets. |
comment:11
Thaaaaaaaaaaaaaaaanks !! Nathann |
As reported on #15278 :
Simplest bug eve : Sage was taught to return the wrong thing. The sum of all arcs in the digraph, plus the sum of all arcs in the reversed digraph. That's clearly more than necessary
:-P
Sorryyyyyyyyyyyyyyyyyyyy !!
Nathann
CC: @simon-king-jena
Component: graph theory
Author: Nathann Cohen
Branch/Commit: u/ncohen/15491 @
020cc82
Reviewer: Simon King
Issue created by migration from https://trac.sagemath.org/ticket/15491
The text was updated successfully, but these errors were encountered: