-
-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate the _boundary parameter #15494
Comments
Branch: u/ncohen/15494 |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Commit: |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:5
Hello Nathann, you should replace all the new |
comment:8
Done Nathann |
comment:10
Hi, It has been waiting long enough. Vincent |
Reviewer: Frédéric Chapoton, Vincent Delecroix |
Changed branch from u/ncohen/15494 to |
From the documentation (
Graph.get_boundary?
orGraph.set_boundary?
) there is just no way to know what it does. So because of that probably nobody uses it. Or they guessed the purpose in some way I can't guess myself.Then there are things like linear-time operations in functions like
.delete_vertex
(noticed by #15278).Sooooooooo unless somebody complains and is willing to write some documentation for this parameter, I think it'd be nice to deprecate then remove it.
Nathan
CC: @simon-king-jena
Component: graph theory
Author: Nathann Cohen
Branch/Commit:
8bb60b3
Reviewer: Frédéric Chapoton, Vincent Delecroix
Issue created by migration from https://trac.sagemath.org/ticket/15494
The text was updated successfully, but these errors were encountered: