Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the _boundary parameter #15494

Closed
nathanncohen mannequin opened this issue Dec 8, 2013 · 12 comments
Closed

Deprecate the _boundary parameter #15494

nathanncohen mannequin opened this issue Dec 8, 2013 · 12 comments

Comments

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Dec 8, 2013

From the documentation (Graph.get_boundary? or Graph.set_boundary?) there is just no way to know what it does. So because of that probably nobody uses it. Or they guessed the purpose in some way I can't guess myself.

Then there are things like linear-time operations in functions like .delete_vertex (noticed by #15278).

self._boundary = [v for v in self._boundary if v != vertex]

Sooooooooo unless somebody complains and is willing to write some documentation for this parameter, I think it'd be nice to deprecate then remove it.

Nathan

CC: @simon-king-jena

Component: graph theory

Author: Nathann Cohen

Branch/Commit: 8bb60b3

Reviewer: Frédéric Chapoton, Vincent Delecroix

Issue created by migration from https://trac.sagemath.org/ticket/15494

@nathanncohen nathanncohen mannequin added this to the sage-6.1 milestone Dec 8, 2013
@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Dec 8, 2013

Branch: u/ncohen/15494

@nathanncohen nathanncohen mannequin added the s: needs review label Dec 8, 2013
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 8, 2013

Branch pushed to git repo; I updated commit sha1. New commits:

[065181c](https://github.com/sagemath/sagetrac-mirror/commit/065181c)trac #15494: Deprecate the graph "boundary" parameter

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 8, 2013

Commit: 065181c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 8, 2013

Changed commit from 065181c to 31a301e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 8, 2013

Branch pushed to git repo; I updated commit sha1. New commits:

[31a301e](https://github.com/sagemath/sagetrac-mirror/commit/31a301e)trac #15494: Deprecate the graph "boundary" parameter

@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@fchapoton
Copy link
Contributor

comment:5

Hello Nathann,

you should replace all the new doctest:1: (or any other number) by doctest:...: because the numbers will change all the time.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 5, 2014

Changed commit from 31a301e to 8bb60b3

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 5, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

c1d7b62trac #15494: Rebase on 6.2.beta3
8bb60b3trac #15494: replacing numbers with ...

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Mar 5, 2014

comment:8

Done

Nathann

@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@videlec
Copy link
Contributor

videlec commented Jun 4, 2014

comment:10

Hi,

It has been waiting long enough.

Vincent

@videlec
Copy link
Contributor

videlec commented Jun 4, 2014

Reviewer: Frédéric Chapoton, Vincent Delecroix

@vbraun
Copy link
Member

vbraun commented Jun 6, 2014

Changed branch from u/ncohen/15494 to 8bb60b3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants