-
-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
key parameter of cached_method is not correctly propagated #16337
Comments
Branch: u/saraedum/ticket/16337 |
This comment has been minimized.
This comment has been minimized.
Author: Julian Rueth |
Commit: |
comment:3
The changes look good to me (and, by the way, I have not been aware that we now have a key parameter for cached methods). So, it will be a positive review, provided that the tests pass (which I am running now). New commits:
|
comment:4
Tests pass, hence, positive review as announced! |
Reviewer: Simon King |
Changed branch from u/saraedum/ticket/16337 to |
In the following example, the last line is incorrect:
It appears that I forgot to propagate the
key
parameter in some places while working on #15657.Component: misc
Author: Julian Rueth
Branch/Commit:
e27e316
Reviewer: Simon King
Issue created by migration from https://trac.sagemath.org/ticket/16337
The text was updated successfully, but these errors were encountered: