Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor real_set.RealInterval #17799

Closed
rwst opened this issue Feb 18, 2015 · 17 comments
Closed

refactor real_set.RealInterval #17799

rwst opened this issue Feb 18, 2015 · 17 comments

Comments

@rwst
Copy link

rwst commented Feb 18, 2015

The class sage.sets.real_set.RealInterval is badly named. Despite being "private" it can be easily confused in the documentation with RealInterval=sage.rings.real_mpfi.RealIntervalFieldElement. The ticket will rename real_set.py:RealInterval.

Component: calculus

Author: Ralf Stephan

Branch/Commit: ef6f40b

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/17799

@rwst rwst added this to the sage-6.6 milestone Feb 18, 2015
@rwst
Copy link
Author

rwst commented Feb 18, 2015

Branch: u/rws/refactor_real_set_realinterval

@rwst
Copy link
Author

rwst commented Feb 18, 2015

New commits:

566688b17799: refactor real_set.py:RealInterval

@rwst
Copy link
Author

rwst commented Feb 18, 2015

Commit: 566688b

@rwst
Copy link
Author

rwst commented Feb 18, 2015

Author: Ralf Stephan

@tscrim
Copy link
Collaborator

tscrim commented Feb 21, 2015

comment:3

You missed this on in the docstring of __init__:

You are not supposed to create :class:`RealInterval` objects

Also could you also move the docstring (except the example block) up to the class level? Thanks.

@rwst
Copy link
Author

rwst commented Feb 21, 2015

comment:4

You haven't read the description: The reason the latter is needed is, although the class is private, its instances can be exposed and users may at least want to create new RealSets from them.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 21, 2015

Changed commit from 566688b to e19c795

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 21, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

3388b08Merge branch 'develop' into t/17799/refactor_real_set_realinterval
e19c79517799: cosmetics

@rwst

This comment has been minimized.

@rwst
Copy link
Author

rwst commented Feb 22, 2015

comment:7

Okay, it's no longer needed by #14801.

@rwst

This comment has been minimized.

@tscrim
Copy link
Collaborator

tscrim commented Feb 26, 2015

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Feb 26, 2015

Changed commit from e19c795 to ef6f40b

@tscrim
Copy link
Collaborator

tscrim commented Feb 26, 2015

comment:8

I made some trivial documentation tweaks. If you're happy them, then positive review.


New commits:

ef6f40bMinor reviewer doc tweaks.

@tscrim
Copy link
Collaborator

tscrim commented Feb 26, 2015

@rwst
Copy link
Author

rwst commented Feb 27, 2015

comment:9

Is fine, thanks.

@vbraun
Copy link
Member

vbraun commented Feb 28, 2015

Changed branch from public/refactor_real_set_realinterval-17799 to ef6f40b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants