-
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor real_set.RealInterval #17799
Comments
New commits:
|
Commit: |
Author: Ralf Stephan |
comment:3
You missed this on in the docstring of
Also could you also move the docstring (except the example block) up to the class level? Thanks. |
comment:4
You haven't read the description: The reason the latter is needed is, although the class is private, its instances can be exposed and users may at least want to create new RealSets from them. |
This comment has been minimized.
This comment has been minimized.
comment:7
Okay, it's no longer needed by #14801. |
This comment has been minimized.
This comment has been minimized.
Reviewer: Travis Scrimshaw |
comment:8
I made some trivial documentation tweaks. If you're happy them, then positive review. New commits:
|
Changed branch from u/rws/refactor_real_set_realinterval to public/refactor_real_set_realinterval-17799 |
comment:9
Is fine, thanks. |
Changed branch from public/refactor_real_set_realinterval-17799 to |
The class
sage.sets.real_set.RealInterval
is badly named. Despite being "private" it can be easily confused in the documentation withRealInterval=sage.rings.real_mpfi.RealIntervalFieldElement
. The ticket will renamereal_set.py:RealInterval
.Component: calculus
Author: Ralf Stephan
Branch/Commit:
ef6f40b
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/17799
The text was updated successfully, but these errors were encountered: