Handle conversion to infinity and int in libgap

[videlec]

We just add support to the following

sage: int(libgap(3))
3
sage: libgap(Infinity).sage()
+Infinity
sage: libgap(-Infinity).sage()
-Infinity
sage: libgap.one()
1

CC: @vbraun

Component: interfaces

Author: Vincent Delecroix

Branch/Commit: cc3297d

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/18153

[videlec]

New commits:

31385f3

Trac 18153: int and infinity from libgap

[videlec]

Commit: 31385f3

[videlec]

Branch: u/vdelecroix/18153

[vbraun]

comment:3

DRY: __int__ is just self.sage(ring=int).

There is also IsNegInfinity for negative infinity...

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

4ec9f5f

Trac 18153: better `__int__` and add support for -infinity

[sagetrac-git]

Changed commit from 31385f3 to 4ec9f5f

[vbraun]

comment:6

How about also adding the other way, libgap(oo) should do the right thing.... e.g. by adding a _libgap_ method to sage.rings.infinity.PlusInfinity. Then you could also clean up the docstrings, the raw libgap.eval isn't what you would want to show to users.

[sagetrac-git]

Changed commit from 4ec9f5f to cdcc7d2

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

cdcc7d2

Trac 18153: sage to gap conversion for infinity

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

57c6685

Trac 18153: sage to gap conversion for infinity

[sagetrac-git]

Changed commit from cdcc7d2 to 57c6685

[sagetrac-git]

Changed commit from 57c6685 to cc3297d

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

cc3297d

Trac 18153: sage to gap conversion for infinity

[videlec]

comment:10

Replying to @vbraun:

How about also adding the other way, libgap(oo) should do the right thing.... e.g. by adding a _libgap_ method to sage.rings.infinity.PlusInfinity. Then you could also clean up the docstrings, the raw libgap.eval isn't what you would want to show to users.

Right! I did implement a _gap_init_ method. That way even the gap interface gets some benefit in it.

Vincent

[vbraun]

Reviewer: Volker Braun

[vbraun]

comment:12

Thanks, lgtm!

[videlec]

comment:13

Thanks for the review.

[vbraun]

Changed branch from u/vdelecroix/18153 to cc3297d