-
-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Huge speed up for hash of quadratic number field elements #18215
Comments
Branch: u/vdelecroix/18215 |
Commit: |
New commits:
|
comment:2
Is there a reason why the hash should be the same as the one for the polynomial? |
comment:3
Replying to @jdemeyer:
No idea. But it make sense. It was the previous implementation. I did not want to break anything. On the other hand, it does not take the parent into account and 'sqrt(2) + 3/2' and 'sqrt(3) + 3/2' would have the same hash. What do you think? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
comment:7
Simpler implementation that is not the one of polynomials (based on 6.7.beta1). |
comment:8
Hello, Can you tell where this |
comment:9
Replying to @nathanncohen:
This is to avoid conflicts for small values of
Yes. This is the same algorithm as Python hash for |
Reviewer: Nathann Cohen |
comment:11
Thanks Nathann! |
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
|
Changed branch from u/vdelecroix/18215 to |
Before
After
... looks like a x500 speed up :-)
As a consequence (and with #18213 applied)
Before
After
See also: #18226
CC: @nathanncohen
Component: number fields
Author: Vincent Delecroix
Branch/Commit:
bee81ef
Reviewer: Nathann Cohen
Issue created by migration from https://trac.sagemath.org/ticket/18215
The text was updated successfully, but these errors were encountered: