-
-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make DirichletGroup a new-style parent #18540
Comments
Commit: |
Work Issues: unpickling of old instances |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Changed work issues from unpickling of old instances to none |
comment:5
A couple of comments:
Looks good otherwise. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:7
Replying to @tscrim:
Done, but only if we know that the group of n-th roots of unity in the base ring is finite. This is currently still the case for all Dirichlet groups that we can construct, but in the future we may admit base rings where this is not the case (the profinite completion of Z, for example).
I don't like this very much. First, the previous implementation actually does not make sense since it depends on a total ordering of all rings. Second, I cannot imagine why one would like to totally order all Dirichlet groups over all rings. |
Reviewer: Jeroen Demeyer |
comment:8
by
(or something similar)
I think it is better to remove |
comment:9
I have no further comments. If you make the above changes and doctests still pass, you can set this to positive_review. |
comment:10
Additional remark: it would be good to fix these
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Changed branch from u/pbruin/18540-DirichletGroup_Parent to |
The purpose of this ticket is to upgrade
DirichletGroup
from an old-styleParentWithMultiplicativeAbelianGens
to a properParent
.At the same time, we place
DirichletGroup
in the category of Abelian groups.Component: number theory
Keywords: Dirichlet group
Author: Peter Bruin
Branch/Commit:
3a2a89b
Reviewer: Jeroen Demeyer
Issue created by migration from https://trac.sagemath.org/ticket/18540
The text was updated successfully, but these errors were encountered: