Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GrowthGroup: short notation factory #18930

Closed
behackl opened this issue Jul 20, 2015 · 33 comments
Closed

GrowthGroup: short notation factory #18930

behackl opened this issue Jul 20, 2015 · 33 comments
Labels
c: asymptotic expansions p: major / 3 t: enhancement
Milestone
sage-6.9

Comments

@behackl
Copy link
Member

behackl commented Jul 20, 2015

For the sake of usability we have introduced a short notation for growth groups (implemented at #17600).

For various reasons, having a factory that is able to generate a growth group from such a "short representation string" is desireable: for example, such a factory enables us to implement a user-friendly way of interacting with the AsymptoticRing (implemented at #17716).

This ticket provides an implementation for such a factory (which can be extended easily to cover cartesian products of growth groups as well).

See #17601 for a roadmap and the planned structure.

Depends on #17600

CC: @dkrenn @cheuberg

Component: asymptotic expansions

Keywords: gsoc15

Author: Benjamin Hackl, Daniel Krenn

Branch/Commit: 4f99031

Reviewer: Daniel Krenn, Clemens Heuberger

Issue created by migration from https://trac.sagemath.org/ticket/18930
@behackl behackl added this to the sage-6.8 milestone Jul 20, 2015
@behackl
Copy link
Member Author

behackl commented Jul 20, 2015

Branch: u/behackl/asy/growthGroup-factory

@behackl
Copy link
Member Author

behackl commented Jul 20, 2015

Last 10 new commits:

73017abconversion from multivariate polynomial rings and multivariate power
a4d5c5f_coerce_map_from_ --> has_coerce_map_from in doctests
ee8272cfixed conversion from multivariate power series rings; replaced PolynomialRing and PowerSeriesRing in doc by bracket-notation
5538893added @experimental to parents
627884cintroduce `_repr_short_` for nicer representation
907e82ddocstrings for _repr*_ methods
6c8b543changed default representation to short representation
2903a9ahelper method for short representation implemented
c916514implemented a helper method for the growth group factory
ae0fff3factory for growth groups implemented

@behackl
Copy link
Member Author

behackl commented Jul 20, 2015

Dependencies: #17600

@behackl
Copy link
Member Author

behackl commented Jul 20, 2015

Commit: ae0fff3

@behackl
Copy link
Member Author

behackl commented Jul 20, 2015

Author: Benjamin Hackl

@behackl

This comment has been minimized.

Sign in to view
@behackl

This comment has been minimized.

Sign in to view
@dkrenn
Copy link
Contributor

dkrenn commented Jul 27, 2015

Changed branch from u/behackl/asy/growthGroup-factory to u/dkrenn/asy/growthGroup-factory

@dkrenn
Copy link
Contributor

dkrenn commented Jul 27, 2015

Last 10 new commits:

30cde4dextend docstring of parent_to_string
1deeeffMerge branch 'asy/6.7/growthGroup' into asy/group-factory
1299e4fextend docstring of string_to_parent
5bc0596small rewritings
ed03ca1rename to parent_to_repr_short
45a37b8rewrite docstring
96435ceMerge branch 'asy/6.7/growthGroup' into asy/group-factory
b7d2273repair
655ec12rename to repr_short_to_parent
e60a325rewrite growth group factory

@dkrenn
Copy link
Contributor

dkrenn commented Jul 27, 2015

Reviewer: Daniel Krenn

@dkrenn
Copy link
Contributor

dkrenn commented Jul 27, 2015

Changed author from Benjamin Hackl to Benjamin Hackl, Daniel Krenn

@dkrenn
Copy link
Contributor

dkrenn commented Jul 27, 2015

Changed commit from ae0fff3 to e60a325

@behackl
Copy link
Member Author

behackl commented Aug 11, 2015

Last 10 new commits:

45a37b8rewrite docstring
96435ceMerge branch 'asy/6.7/growthGroup' into asy/group-factory
b7d2273repair
655ec12rename to repr_short_to_parent
e60a325rewrite growth group factory
ea8ae66repr-option to suppress words "Growth Group"
b7f5c73rename repr-option-keyword and minor change in output
c0ec9fdminor change in output of repr
f141775typos in module description fixed
62d824fMerge branch 'asy/growthGroup' into asy/growthGroup-factory

@behackl
Copy link
Member Author

behackl commented Aug 11, 2015

Changed branch from u/dkrenn/asy/growthGroup-factory to u/behackl/asy/growthGroup-factory

@behackl
Copy link
Member Author

behackl commented Aug 11, 2015

Changed commit from e60a325 to 62d824f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 13, 2015

Changed commit from 62d824f to ba16c0f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 13, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

164d21ecompare exponents directly instead with is_le_one
baa8f7cimplemented gens_monomial and adapted gen, gens, ngens
b477c62merge branch 'asy/growthGroup' into asy/growthGroup-factory and resolve a minor conflict
3749fa1refactored handling of generators
ba16c0fMerge branch 'asy/growthGroup' into asy/growthGroup-factory

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 14, 2015

Changed commit from ba16c0f to 3564d23

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 14, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

c6d8584error with the element constructor fixed, doctest added
3564d23Merge branch 'asy/growthGroup' into asy/growthGroup-factory

@dkrenn
Copy link
Contributor

dkrenn commented Aug 20, 2015

comment:11

During the project #17601 (the last months in course of GSOC2015 as mentor) I did a very careful reviewing of all code. This includes the code of this ticket. Now this is clearly a positive_review from my side.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 20, 2015

Changed commit from 3564d23 to 032d8b8

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 20, 2015

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

1688a84Merge branch 'asy/growthGroup' into asy/growthGroup-factory
d5fdd04collect asymptotic code in one directory
e8662cdcollect asymptotic code in one directory
c5f0dacMerge branch 'asy/growthGroup' into asy/growthGroup-factory
7774ff2fixed doctests
878ef2afixed documentation build
5fd9662Merge branch 'asy/growthGroup' into asy/growthGroup-factory
f20c42efixing doctests
1c81c12language oddities fixed
032d8b8Merge branch 'asy/growthGroup' into asy/growthGroup-factory

@dkrenn
Copy link
Contributor

dkrenn commented Sep 9, 2015

Changed branch from u/behackl/asy/growthGroup-factory to u/dkrenn/asy/growthGroup-factory

@dkrenn
Copy link
Contributor

dkrenn commented Sep 9, 2015

comment:14

Merged 6.9.beta5

New commits:

3a05be7Merge tag '6.9.beta5' into t/17600/asy/growthGroup
58f931dadd asymptotic_expansions index
9d6f2daMerge branch 't/17600/asy/growthGroup' into t/18930/asy/growthGroup-factory

@dkrenn
Copy link
Contributor

dkrenn commented Sep 9, 2015

Changed commit from 032d8b8 to 9d6f2da

@cheuberg
Copy link
Contributor

Changed branch from u/dkrenn/asy/growthGroup-factory to u/cheuberg/asy/growthGroup-factory

@cheuberg
Copy link
Contributor

comment:17

I reviewed this and added two reviewer commits.

Doctests pass and documentation builds and is adequate, code seems to be fine.

Please cross-review my changes and set the ticket to positive_review if you are satisfied.

New commits:

b89fa2dTrac #18930: expand docstring of repr_short_to_parent
eaa1453Trac #18930: tuple for format to be on the safe side

@cheuberg
Copy link
Contributor

Changed commit from 9d6f2da to eaa1453

@cheuberg
Copy link
Contributor

Changed reviewer from Daniel Krenn to Daniel Krenn, Clemens Heuberger

@cheuberg cheuberg modified the milestones: sage-6.8, sage-6.9 Sep 16, 2015
@behackl
Copy link
Member Author

behackl commented Sep 16, 2015

Changed branch from u/cheuberg/asy/growthGroup-factory to u/behackl/asy/growthGroup-factory

@behackl
Copy link
Member Author

behackl commented Sep 16, 2015

comment:18

I cross-reviewed your changes, and merged the final version of the positively reviewed ticket #17600 into this branch. LGTM; thanks for the review!

Last 10 new commits:

c4dca20Trac #17600: Punctuation
1ab1334Trac #17600: fix incorrect link
1c7a521corrected INPUT-section of parent_to_repr_short
6dee8b7abstract implementation --> basic implementation
3f88a9aduplicate doctest removed
9489badelement_constructor: input clarification; doctests marked as indirect
053ee33type(...) == ... --> isinstance(...)
7b49489clarification gens vs. gens_monomial
2bf6868prevent strange NotImplementedError from PowerSeriesRing
4f99031Merge branch 'asy/growthGroup' into asy/growthGroup-factory

@behackl
Copy link
Member Author

behackl commented Sep 16, 2015

Changed commit from eaa1453 to 4f99031

@vbraun
Copy link
Member

vbraun commented Sep 17, 2015

Changed branch from u/behackl/asy/growthGroup-factory to 4f99031

@vbraun vbraun closed this as completed in e191893 Sep 17, 2015
This was referenced Dec 29, 2022
Open
Closed
@dkrenn dkrenn mentioned this issue Oct 21, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: asymptotic expansions p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-6.9
Development

No branches or pull requests
4 participants
@vbraun @cheuberg @behackl @dkrenn