AsymptoticRing: convert Orders of symbolic ring

[dkrenn]

Implement conversion from Order(...) to asymptotic rings.

(There seems to be a bug in SR (#19425) which has to be solved first.)

Depends on #19083
Depends on #19425

CC: @behackl

Component: asymptotic expansions

Work Issues: rebase

Author: Eran Assaf

Branch/Commit: u/assaferan/asymptoticring__convert_orders_of_symbolic_ring @ 90152f3

Reviewer: Benjamin Hackl

Issue created by migration from https://trac.sagemath.org/ticket/19426

[cheuberg]

Changed dependencies from #19083, #19424 to #19083, #19425

[assaferan]

Branch: u/assaferan/asymptoticring__convert_orders_of_symbolic_ring

[assaferan]

New commits:

bd4a461	Changed brial installation to support cygwin 64-bit with the new limits.h
60c5606	Fixed Ticket #19426 - Implemented conversion from Order(...) to asymptotic rings.
cd2f1a4	Added conversion from Symbolic Order to Asymptotic Ring.
45ec3d7	Added an appropriate doctest

[assaferan]

Author: Eran Assaf

[assaferan]

Commit: 45ec3d7

[behackl]

Reviewer: Benjamin Hackl

[behackl]

comment:6

Hi! Your basic approach looks good, however, you should merge the latest beta (8.2.beta8) into your branch and fix the resulting merge conflict with your adaption of the brial configuration. (This issue has been fixed in #24860, which is merged in beta8.)

As a suggestion: you should keep fixes for unrelated problems (like in this case the brial problem) separate from the code for this ticket (basically, separate fixes deserve separate tickets).

I'll review this as soon as the conflict is resolved.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

90152f3

merged latest beta code with mine

[sagetrac-git]

Changed commit from 45ec3d7 to 90152f3

[assaferan]

comment:8

Hi!
I've fixed the conflict and committed the changes.

In principal, I agree with your suggestion. The problem was I could not build sage on my PC without fixing this problem, and it took a while until I could get everything to work (trac user, git, etc.).

Anyway, hopefully it can be reviewed now.
Thanks,
Eran

[RelationaleDB]

comment:9

merge conflict

[RelationaleDB]

Work Issues: rebase

[DaveWitteMorris]

comment:10

Removing the "beginner" tag from old tickets. Some could be returned to beginner-friendly status by adding a comment about what needs to be done. Some others might be easy for an experienced developer to finish.