Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixup of 19431: convert asymptotic expansion to the symbolic ring #19436

Closed
dkrenn opened this issue Oct 19, 2015 · 7 comments
Closed

fixup of 19431: convert asymptotic expansion to the symbolic ring #19436

dkrenn opened this issue Oct 19, 2015 · 7 comments
Labels
c: asymptotic expansions p: major / 3 t: bug
Milestone
sage-6.10

Comments

@dkrenn
Copy link
Contributor

dkrenn commented Oct 19, 2015

#19431 changed SymbolicRing._element_constructor_ which was not needed. A method _symbolic_ suffices in the AsymptoticRing. An additional parameter R in .symbolic_expression will be needed to make it work.

Depends on #19431

CC: @behackl @cheuberg @rwst

Component: asymptotic expansions

Author: Daniel Krenn

Branch/Commit: ee52932

Reviewer: Clemens Heuberger

Issue created by migration from https://trac.sagemath.org/ticket/19436
@dkrenn dkrenn added this to the sage-6.10 milestone Oct 19, 2015
@dkrenn
Copy link
Contributor Author

dkrenn commented Oct 19, 2015

Branch: u/dkrenn/asy-to-SR

@dkrenn
Copy link
Contributor Author

dkrenn commented Oct 19, 2015

Author: Daniel Krenn

@dkrenn
Copy link
Contributor Author

dkrenn commented Oct 19, 2015

Last 10 new commits:

5327238doctests: rewrite >>... to >...>
ef4ebb1rewrite main substitution method
2f434d7write doc and many doctests for substitute
875542dwrite AsymptoticExpansion.symbolic_expression
5ac0feaextend SR._element_constructor_ to accept asymptotic expansions
fa814b0Trac #19431: merge 6.10.beta0
6a6efc4introduce parameter R in .symbolic_expression
f39b942simplify SR._element_constructor
5c3cba3fix checks whether parent is SR to check if instance of SymbolicRing
ee52932fixup and doctest of parameter R in .symbolic_expression

@dkrenn
Copy link
Contributor Author

dkrenn commented Oct 19, 2015

Commit: ee52932

@cheuberg
Copy link
Contributor

comment:4

LGTM.

doctests pass, documentation builds, code seems to be fine.

@cheuberg
Copy link
Contributor

Reviewer: Clemens Heuberger

@vbraun
Copy link
Member

vbraun commented Oct 24, 2015

Changed branch from u/dkrenn/asy-to-SR to ee52932

@vbraun vbraun closed this as completed in a016066 Oct 24, 2015
@behackl behackl mentioned this issue Dec 29, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: asymptotic expansions p: major / 3 t: bug
Projects
None yet
Milestone
sage-6.10
Development

No branches or pull requests
3 participants
@vbraun @cheuberg @dkrenn