Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map_coefficients for asymptotic expansions #19528

Closed
dkrenn opened this issue Nov 4, 2015 · 13 comments
Closed

map_coefficients for asymptotic expansions #19528

dkrenn opened this issue Nov 4, 2015 · 13 comments

Comments

@dkrenn
Copy link
Contributor

dkrenn commented Nov 4, 2015

Write a method which transforms asymptotic expansions by applying a function on its coefficients.

CC: @behackl

Component: asymptotic expansions

Author: Daniel Krenn

Branch/Commit: d62912f

Reviewer: Clemens Heuberger

Issue created by migration from https://trac.sagemath.org/ticket/19528

@dkrenn dkrenn added this to the sage-6.10 milestone Nov 4, 2015
@dkrenn
Copy link
Contributor Author

dkrenn commented Nov 4, 2015

Branch: u/dkrenn/asy/map_coefficients

@dkrenn
Copy link
Contributor Author

dkrenn commented Nov 4, 2015

Commit: bdcb72b

@dkrenn
Copy link
Contributor Author

dkrenn commented Nov 4, 2015

New commits:

421e377mutable poset map: remove elements ``None``
1d28240term monoid: write change_parameter
2c37889correct a bug in change_parameter
bdcb72bwrite map_coefficients

@cheuberg
Copy link
Contributor

Changed branch from u/dkrenn/asy/map_coefficients to u/cheuberg/asy/map_coefficients

@cheuberg
Copy link
Contributor

Changed commit from bdcb72b to 8a71ba3

@cheuberg
Copy link
Contributor

Reviewer: Clemens Heuberger

@cheuberg
Copy link
Contributor

comment:4

One reviewer commit and to minor issues:

  1. TermMonoidFactory. When reading its documentation because it was used by change_parameter, I am no longer happy with the description (and probably also the name) of the parameter term: "or an existing instance of a term." should be replaced by "or an existing instance of a term monoid". Also "the kind of term that shall be created" is not really precise ("the kind of terms held in the new term monoid")
  2. map_coefficients: == 0 vs. is_zero()?

New commits:

8a71ba3Trac #19528: simplification of documentation

@cheuberg
Copy link
Contributor

comment:5

The build error by the patchbot Athena seems to be unrelated to this ticket.

@cheuberg cheuberg modified the milestones: sage-6.10, sage-7.1 Jan 21, 2016
@dkrenn
Copy link
Contributor Author

dkrenn commented Jan 21, 2016

Changed branch from u/cheuberg/asy/map_coefficients to u/dkrenn/asy/map_coefficients

@dkrenn
Copy link
Contributor Author

dkrenn commented Jan 21, 2016

Changed commit from 8a71ba3 to d62912f

@dkrenn
Copy link
Contributor Author

dkrenn commented Jan 21, 2016

New commits:

dc9d496Trac #19528: rename term to term_monoid and improve doc
d62912fTrac #19528: change "== 0" to ".is_zero()"

@cheuberg
Copy link
Contributor

comment:8

LGTM.

@vbraun
Copy link
Member

vbraun commented Jan 23, 2016

Changed branch from u/dkrenn/asy/map_coefficients to d62912f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants