asymptotic expansion generators related to singularity analysis #19532

dkrenn · 2015-11-06T00:50:24Z

Create asymptotic expansions coming from pole singularities.

Depends on #19437
Depends on #19510
Depends on #19576
Depends on #19946
Depends on #19898

CC: @behackl @cheuberg

Component: asymptotic expansions

Author: Daniel Krenn

Branch/Commit: a4eaf82

Reviewer: Clemens Heuberger

Issue created by migration from https://trac.sagemath.org/ticket/19532

The text was updated successfully, but these errors were encountered:

dkrenn · 2015-11-06T00:50:44Z

Branch: u/dkrenn/asy/singularity-analysis

dkrenn · 2015-11-06T00:51:12Z

comment:2

Implemented pole singularities.

Last 10 new commits:

`e93ce46`	`simplify coefficients automatically and use the faster algorithm per default`
`f468de6`	`docu`
`4a27e66`	`result over QQ if skip-parameter given`
`e59c71f`	`toc entry (at top of file)`
`e1aca77`	`SR.symbol: set parent correctly (inheritance)`
`9ac89ae`	`Move pynac_symbol_registry to cdef attribute SR.symbols`
`e06f8ae`	`Merge branch 'u/jdemeyer/symbolic/sub-var' of trac.sagemath.org:sage into asy/singularity-analysis`
`f2573a9`	`calculate coefficients of singularity analysis (pole type)`
`b2e375f`	`generator SingularityAnalysis (pole type)`
`3214c83`	`explicitly specify a default default-precision`

dkrenn · 2015-11-06T00:51:12Z

Commit: 3214c83

sagetrac-git · 2015-11-07T00:43:47Z

Changed commit from 3214c83 to 8ec2dfd

sagetrac-git · 2015-11-07T00:43:47Z

Branch pushed to git repo; I updated commit sha1. New commits:

`8ec2dfd`	`fix docstring`

cheuberg · 2016-01-22T04:43:33Z

Changed branch from u/dkrenn/asy/singularity-analysis to u/cheuberg/asy/singularity-analysis

sagetrac-git · 2016-01-22T04:48:04Z

Changed commit from 8ec2dfd to ab1cd26

sagetrac-git · 2016-01-22T04:48:04Z

Branch pushed to git repo; I updated commit sha1. New commits:

`8f7195f`	`Trac #19576: parentheses around coefficients of asymptotic expansions`
`ab1cd26`	`Trac #19532: Merge #19576 to fix doctest`

sagetrac-git · 2016-01-22T04:48:54Z

Changed commit from ab1cd26 to 9796508

sagetrac-git · 2016-01-22T04:48:54Z

Branch pushed to git repo; I updated commit sha1. New commits:

`9796508`	`Trac #19532: fix doctest`

cheuberg · 2016-01-22T04:54:49Z

comment:7

My impression is that you implemented poles and still want to implement logarithmic singularities in the same ticket. I'd suggest to restrict this ticket to poles (and raising NotImplementedError for the logarithmic singularities, as apparently done in the current code) and to leave extensions to future tickets.

cheuberg · 2016-01-22T15:42:05Z

Changed dependencies from #19437, #19510 to #19437, #19510, #19576

sagetrac-git · 2016-01-22T17:41:25Z

Branch pushed to git repo; I updated commit sha1. New commits:

`f114f9e`	`Trac #19532: Add to table of contents`
`ede5173`	`Trac #19532: Minor documentation fixes`
`267718d`	`Trac #19532: Additional tests`
`0860173`	`Trac #19532: List log log factors, document missing implementations`
`a3a6dfd`	`Trac #19532: Add references`

sagetrac-git · 2016-01-22T17:41:25Z

Changed commit from 9796508 to a3a6dfd

cheuberg · 2016-01-22T17:49:36Z

Reviewer: Clemens Heuberger

cheuberg · 2016-01-22T17:49:36Z

comment:11

I reviewed the code, doctests pass, documentation and code are mostly fine. I added a few reviewer commits, please cross-review.

There is only the question on what to do with integral alpha <= 0. Currently, the result is 0 which is certainly correct for sufficiently large values of the parameter. However, the rest of the asymptotics code as I remember it does not really assume "sufficiently large values of the parameter".

I am not really sure which result is appropriate. Several options:

0 - valid for sufficiently large values of the parameter. (current version)
O(1) - correct, but bad for applications.
raise an error
add a warning to the documentation
add a note to the documentation

cheuberg · 2016-01-22T19:22:19Z

comment:12

zeta != 1 is not implemented.

sagetrac-git · 2016-01-23T05:28:20Z

Changed commit from a3a6dfd to 7f74b31

sagetrac-git · 2016-01-23T05:28:20Z

Branch pushed to git repo; I updated commit sha1. New commits:

`ea3dd35`	`small bugfix`
`1529a4d`	`Trac #19510: Merge #19306 (due to #19879)`
`b30388b`	`Trac #19532: Merge #19510 to fix doctest`
`7f74b31`	`Trac #19532: Implement zeta != 1`

sagetrac-git · 2016-01-23T05:35:21Z

Changed commit from 7f74b31 to f6a233d

cheuberg · 2016-01-25T20:25:30Z

comment:24

LGTM. Setting to positive despite the dependency: the dependency is only in order to avoid a merge conflict (inserting new methods at the same position); so no changes are necessary here anyway independently of the fate of #19510.

cheuberg · 2016-01-26T16:29:23Z

Changed branch from u/dkrenn/asy/singularity-analysis-generator to u/cheuberg/asy/singularity-analysis-generator

cheuberg · 2016-01-26T16:30:45Z

Changed dependencies from #19437, #19510, #19576 to #19437, #19510, #19576, #19946

cheuberg · 2016-01-26T16:30:45Z

comment:26

Merged #19946 and removed work-around for #19946; please cross-review.

New commits:

`1fc00c7`	Trac #19946: fix `_pushout_` for cartesian product of growth groups
`1b62954`	`Trac #19946: add doctests to document behavior`
`24c153c`	`Trac #19946: reviewer commit: ReSt error`
`7918417`	`Trac #19946: additional doctest`
`bfb72dc`	`Trac #19532: Merge #19946`
`21054cb`	`Trac #19532: get rid of work-around for #19946`

cheuberg · 2016-01-26T16:30:45Z

Changed commit from 2dff051 to 21054cb

dkrenn · 2016-01-27T09:38:24Z

Changed branch from u/cheuberg/asy/singularity-analysis-generator to u/dkrenn/asy/singularity-analysis-generator

dkrenn · 2016-01-27T09:39:46Z

Changed commit from 21054cb to a71b84a

dkrenn · 2016-01-27T09:39:46Z

comment:28

I've merged in the dependency #19510 due to changes there and merge-conflicts here.

Last 10 new commits:

`5d9152c`	`Trac #19510: state constant factors/summands in Stirling and binomial`
`2db9105`	`Trac #19510: separate calculation of negative powers in log_Stirling`
`1471336`	`Trac #19946: rewrite and improve explaination of 1b62954`
`9f9a23f`	`Trac #19961: document rpow`
`101e4de`	`Merge branch 'u/dkrenn/t/19961' of trac.sagemath.org:sage into t/19946`
`7179c78`	`Trac #19946: link from general doc to detailed explaination`
`1259201`	`Trac #19946: fix typo`
`37caf25`	`Merge branch 'u/cheuberg/t/19946' of trac.sagemath.org:sage into t/19510/asy/generators-binomial`
`10cd04b`	`Trac #19510: major rewrite of binomial kn over n`
`a71b84a`	`Merge remote-tracking branch 'trac/u/dkrenn/asy/generators-binomial' into t/19532/asy/singularity-analysis-generator`

sagetrac-git · 2016-01-27T10:24:40Z

Branch pushed to git repo; I updated commit sha1. New commits:

`4c58608`	`Trac #19898: Generator for expansion of harmonic number`
`adae74b`	`Trac #19898: Merge #19510 to resolve conflicts`
`ef9cb08`	`Trac #19898: Merge #19306 (due to #19879)`
`e193ac1`	`Trac #19898: sage.rings.arith -> sage.arith.all (after #19879)`
`bedd23a`	`Trac #19898: rename harmonic_number to HarmonicNumber`
`27e9e69`	`Trac #19898: state constant summand in documentation`
`209329d`	`Merge branch 'u/dkrenn/asy/generators-binomial' of trac.sagemath.org:sage into t/19898/asy/harmonic-number`
`4ad4524`	`Merge branch 'u/dkrenn/asy/harmonic-number' of trac.sagemath.org:sage into t/19532/asy/singularity-analysis-generator`

sagetrac-git · 2016-01-27T10:24:40Z

Changed commit from a71b84a to 4ad4524

dkrenn · 2016-01-27T10:27:14Z

Changed dependencies from #19437, #19510, #19576, #19946 to #19437, #19510, #19576, #19946, #19898

dkrenn · 2016-01-27T10:27:14Z

comment:30

Merge in #19898 to avoid a merge conflict. (Git is able to merge automatically if #19898 is handled first.)

cheuberg · 2016-01-27T13:51:35Z

Changed branch from u/dkrenn/asy/singularity-analysis-generator to u/cheuberg/asy/singularity-analysis-generator

cheuberg · 2016-01-27T13:53:00Z

Changed commit from 4ad4524 to 2b95429

cheuberg · 2016-01-27T13:53:00Z

comment:32

Merged #19898 once more and added a doctest; please review this new doctest and then set to positive if satisfied.

Last 10 new commits:

`3d51289`	`Trac #19957: Merge #19946 to avoid work-around`
`b606fdf`	`Trac #19957: remove work-around for #19946`
`4346994`	`Trac #19957: rename e to expansion in doctests`
`5d6e9b2`	`Trac #19957: Introduce parameter relative tolerance`
`00eae5d`	`Merge branch 't/19957/asy/compare-with-values' into t/19510/asy/generators-binomial`
`78bdd0f`	`Trac #19510: additional doctests using compare_with_values`
`148eabb`	`Trac #19898: Merge #19510`
`a66c377`	`Trac #19898: additional doctest using compare_with_values`
`5dc6f58`	`Trac #19532: Merge #19898`
`2b95429`	`Trac #19532: additional doctest using compare_with_values`

sagetrac-git · 2016-01-30T14:24:10Z

Changed commit from 2b95429 to a4eaf82

sagetrac-git · 2016-01-30T14:24:10Z

Branch pushed to git repo; I updated commit sha1. New commits:

`a4eaf82`	`Trac #19532: add relative tolerance to doctests introduced on this ticket`

vbraun · 2016-02-01T08:23:38Z

Changed branch from u/cheuberg/asy/singularity-analysis-generator to a4eaf82

dkrenn added this to the sage-6.10 milestone Nov 6, 2015

dkrenn added c: asymptotic expansions labels Nov 6, 2015

cheuberg modified the milestones: sage-6.10, sage-7.1 Jan 22, 2016

dkrenn added the s: needs review label Jan 22, 2016

This comment has been minimized.

Sign in to view

cheuberg added s: needs info and removed s: needs review labels Jan 22, 2016

cheuberg added s: positive review and removed s: needs review labels Jan 25, 2016

cheuberg added s: needs review and removed s: positive review labels Jan 26, 2016

dkrenn added s: positive review and removed s: needs review labels Jan 30, 2016

vbraun removed the s: positive review label Feb 1, 2016

vbraun closed this as completed in 38fdacc Feb 1, 2016

This was referenced Dec 29, 2022

Meta ticket: Asymptotic Expansions in SageMath #17601

Open

asymptotic expansions: singularity analysis #19944

Closed

cheuberg mentioned this issue Jan 8, 2018

Asymptotic Ring: cannot construct 2^n when coefficient ring is SR #19946

Closed

behackl mentioned this issue Feb 15, 2016

asymptotic expansion generator: singularity analysis (log-type) #19969

Closed

asymptotic expansion generators related to singularity analysis #19532

asymptotic expansion generators related to singularity analysis #19532

Comments

dkrenn commented Nov 6, 2015

dkrenn commented Nov 6, 2015

dkrenn commented Nov 6, 2015

dkrenn commented Nov 6, 2015

sagetrac-git mannequin commented Nov 7, 2015

sagetrac-git mannequin commented Nov 7, 2015

cheuberg commented Jan 22, 2016

sagetrac-git mannequin commented Jan 22, 2016

sagetrac-git mannequin commented Jan 22, 2016

sagetrac-git mannequin commented Jan 22, 2016

sagetrac-git mannequin commented Jan 22, 2016

cheuberg commented Jan 22, 2016

cheuberg commented Jan 22, 2016

sagetrac-git mannequin commented Jan 22, 2016

sagetrac-git mannequin commented Jan 22, 2016

This comment has been minimized.

cheuberg commented Jan 22, 2016

cheuberg commented Jan 22, 2016

cheuberg commented Jan 22, 2016

sagetrac-git mannequin commented Jan 23, 2016

sagetrac-git mannequin commented Jan 23, 2016

sagetrac-git mannequin commented Jan 23, 2016

cheuberg commented Jan 25, 2016

cheuberg commented Jan 26, 2016

cheuberg commented Jan 26, 2016

cheuberg commented Jan 26, 2016

cheuberg commented Jan 26, 2016

dkrenn commented Jan 27, 2016

dkrenn commented Jan 27, 2016

dkrenn commented Jan 27, 2016

sagetrac-git mannequin commented Jan 27, 2016

sagetrac-git mannequin commented Jan 27, 2016

dkrenn commented Jan 27, 2016

dkrenn commented Jan 27, 2016

cheuberg commented Jan 27, 2016

cheuberg commented Jan 27, 2016

cheuberg commented Jan 27, 2016

sagetrac-git mannequin commented Jan 30, 2016

sagetrac-git mannequin commented Jan 30, 2016

vbraun commented Feb 1, 2016