-
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 4ti2 to version 1.6.7 #19693
Comments
Commit: |
This comment has been minimized.
This comment has been minimized.
New commits:
|
Author: Matthias Koeppe |
comment:3
#18459 was just an update. It had nothing to do with the package type (experimental/optional/standard). Surely 4ti2 has been around for long enough to become optional or standard. There was a massive patch setting package types:
We should hold a vote on sage-devel to promote it to optional. (For this it must not fail any tests, etc). |
comment:4
You can setup a vote if you prefer, but I do not remember it being mandatory for a new optional package. It was only switched to experimental because it did not pass all optional tests at that time. Nathann |
comment:5
Replying to @nathanncohen:
OK, then how about flipping type to 'optional' and proceeding? |
comment:6
otherwise, looks good to me. To allow bots to test this properly, commit the change of type, please. |
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
|
Reviewer: Dima Pasechnik |
comment:9
Replying to @nathanncohen:
Indeed. So make absolutely sure that the optional tests pass. |
This comment has been minimized.
This comment has been minimized.
Changed branch from u/mkoeppe/update_4ti2_to_version_1_6_7 to |
This is a bugfix release.
The new tarball is here:
http://www.4ti2.de/version_1.6.7/4ti2-1.6.7.tar.gz
Oh, and what's up with the big warning about the package being experimental? Introduced with #18563.
CC: @jdemeyer @dimpase @nathanncohen
Component: packages: optional
Author: Matthias Koeppe
Branch/Commit:
0ee2b2e
Reviewer: Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/19693
The text was updated successfully, but these errors were encountered: