Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 4ti2 to version 1.6.7 #19693

Closed
mkoeppe opened this issue Dec 12, 2015 · 15 comments
Closed

Update 4ti2 to version 1.6.7 #19693

mkoeppe opened this issue Dec 12, 2015 · 15 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 12, 2015

This is a bugfix release.

The new tarball is here:
http://www.4ti2.de/version_1.6.7/4ti2-1.6.7.tar.gz

Oh, and what's up with the big warning about the package being experimental? Introduced with #18563.

CC: @jdemeyer @dimpase @nathanncohen

Component: packages: optional

Author: Matthias Koeppe

Branch/Commit: 0ee2b2e

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/19693

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 12, 2015

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 12, 2015

Commit: afbc85f

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 12, 2015

New commits:

afbc85fUpdate 4ti2 to version 1.6.7

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 12, 2015

Author: Matthias Koeppe

@dimpase
Copy link
Member

dimpase commented Dec 12, 2015

comment:3

#18459 was just an update. It had nothing to do with the package type (experimental/optional/standard). Surely 4ti2 has been around for long enough to become optional or standard. There was a massive patch setting package types:

>build/pkgs/4ti2$ git blame type
ef11087e (Jeroen Demeyer 2015-06-01 10:12:49 +0200 1) experimental

We should hold a vote on sage-devel to promote it to optional. (For this it must not fail any tests, etc).

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Dec 12, 2015

comment:4

We should hold a vote on sage-devel to promote it to optional. (For this it must not fail any tests, etc).

You can setup a vote if you prefer, but I do not remember it being mandatory for a new optional package. It was only switched to experimental because it did not pass all optional tests at that time.

Nathann

@dimpase
Copy link
Member

dimpase commented Dec 12, 2015

comment:5

Replying to @nathanncohen:

We should hold a vote on sage-devel to promote it to optional. (For this it must not fail any tests, etc).

You can setup a vote if you prefer, but I do not remember it being mandatory for a new optional package. It was only switched to experimental because it did not pass all optional tests at that time.

OK, then how about flipping type to 'optional' and proceeding?

@dimpase
Copy link
Member

dimpase commented Dec 12, 2015

comment:6

otherwise, looks good to me. To allow bots to test this properly, commit the change of type, please.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 12, 2015

Changed commit from afbc85f to 0ee2b2e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 12, 2015

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

0ee2b2eChange type to optional.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 12, 2015

Reviewer: Dima Pasechnik

@jdemeyer
Copy link

comment:9

Replying to @nathanncohen:

You can setup a vote if you prefer, but I do not remember it being mandatory for a new optional package. It was only switched to experimental because it did not pass all optional tests at that time.

Indeed. So make absolutely sure that the optional tests pass.

@jdemeyer

This comment has been minimized.

@vbraun
Copy link
Member

vbraun commented Dec 22, 2015

Changed branch from u/mkoeppe/update_4ti2_to_version_1_6_7 to 0ee2b2e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants