Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

singularity in formula in docstring of SingularityAnalysis-generator #20049

Closed
dkrenn opened this issue Feb 14, 2016 · 12 comments
Closed

singularity in formula in docstring of SingularityAnalysis-generator #20049

dkrenn opened this issue Feb 14, 2016 · 12 comments

Comments

@dkrenn
Copy link
Contributor

dkrenn commented Feb 14, 2016

        .. MATH::

            [z^n] \left(\frac{1}{1-z}\right)^\alpha
            \left(\frac{1}{z} \log \frac{1}{1-z}\right)^\beta
            \left(\frac{1}{z} \log
            \left(\frac{1}{z} \log \frac{1}{1-z}\right)\right)^\delta.

does not depend on the singularity \zeta, which is incorrect (and not mentioned at all).

Depends on #19969

CC: @behackl @cheuberg

Component: asymptotic expansions

Keywords: singularity analysis

Author: Daniel Krenn

Branch/Commit: d3b48c7

Reviewer: Clemens Heuberger

Issue created by migration from https://trac.sagemath.org/ticket/20049

@dkrenn
Copy link
Contributor Author

dkrenn commented Feb 14, 2016

comment:1

We can either change to

        .. MATH::

            [z^n] \left(\frac{1}{1-z/\zeta}\right)^\alpha
            \left(\frac{1}{z/\zeta} \log \frac{1}{1-z/\zeta}\right)^\beta
            \left(\frac{1}{z/\zeta} \log
            \left(\frac{1}{z/\zeta} \log \frac{1}{1-z/\zeta}\right)\right)^\delta.

or prepend a (1/\zeta)^n to the formula.

@dkrenn
Copy link
Contributor Author

dkrenn commented Feb 14, 2016

Branch: u/dkrenn/asy/SA-generator-log

@dkrenn
Copy link
Contributor Author

dkrenn commented Feb 14, 2016

Changed branch from u/dkrenn/asy/SA-generator-log to none

@dkrenn
Copy link
Contributor Author

dkrenn commented Feb 14, 2016

Branch: u/dkrenn/zeta-in-GF

@dkrenn
Copy link
Contributor Author

dkrenn commented Feb 14, 2016

Author: Daniel Krenn

@dkrenn
Copy link
Contributor Author

dkrenn commented Feb 14, 2016

comment:5

Replying to @dkrenn:

We can either change to

        .. MATH::

            [z^n] \left(\frac{1}{1-z/\zeta}\right)^\alpha
            \left(\frac{1}{z/\zeta} \log \frac{1}{1-z/\zeta}\right)^\beta
            \left(\frac{1}{z/\zeta} \log
            \left(\frac{1}{z/\zeta} \log \frac{1}{1-z/\zeta}\right)\right)^\delta.

or prepend a (1/\zeta)^n to the formula.

The first choice does not look that bad, so I've prepared a patch.


Last 10 new commits:

c2f30f5move code of NotImplementedOZero to avoid merge-conflicts
ebac5c2Trac #20043: add additional doctest to check parent
33f675dMerge branch 'u/dkrenn/asy/one-times-zero' of trac.sagemath.org:sage into t/19969/asy/SA-generator-log
98e1fc7Trac #20043: make error message more precise and flexibel
99d7292Merge branch 't/20043/asy/one-times-zero' into t/19969/asy/SA-generator-log
dd7dabfTrac #19969: fix doctest
617e5bfTrac #19969: rewrite output of doctest so that comparison with Formula in Flajolet-Sedgewick is easier
456d8c3Trac #19969: correct whitespaces
b540598Trac #19969: add an additional doctest
d3b48c7Trac #20049: \zeta in GF in SingularityAnalysis-generator

@dkrenn
Copy link
Contributor Author

dkrenn commented Feb 14, 2016

Commit: d3b48c7

@cheuberg
Copy link
Contributor

Dependencies: #19969

@cheuberg
Copy link
Contributor

Reviewer: Clemens Heuberger

@cheuberg
Copy link
Contributor

Changed keywords from none to singularity analysis

@cheuberg
Copy link
Contributor

comment:6

LGTM

@vbraun
Copy link
Member

vbraun commented Feb 15, 2016

Changed branch from u/dkrenn/zeta-in-GF to d3b48c7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants