Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename AsymptoticRing.singularity_analysis to coefficients_of_generating_function #20056

Closed
cheuberg opened this issue Feb 15, 2016 · 9 comments

Comments

@cheuberg
Copy link
Contributor

Rename AsymptoticRing.singularity_analysis to AsymptoticRing.coefficients_of_generating_function in order to describe what the method does instead of how it does it.

Furthermore, in #20053, we will introduce a method AsymptoticExpansion.singularity_analysis and it seems to be better to have different names for related, but not identical functionalities.

Depends on #20040

CC: @dkrenn @behackl

Component: asymptotic expansions

Author: Clemens Heuberger

Branch/Commit: 40b6e2e

Reviewer: Daniel Krenn

Issue created by migration from https://trac.sagemath.org/ticket/20056

@cheuberg
Copy link
Contributor Author

@cheuberg
Copy link
Contributor Author

Dependencies: #20040

@cheuberg

This comment has been minimized.

@cheuberg
Copy link
Contributor Author

Commit: 40b6e2e

@cheuberg
Copy link
Contributor Author

Last 10 new commits:

902c182Trac #20040: Merge #19944
866a9e3Trac #20040: exchange order of parameters var and zeta in _singularity_analysis_
c79a6f7Trac #19944: exchange zeta and var in docstrings
d0f5e94Trac #20040: Merge #19944
27a8605Merge branch 'u/cheuberg/asy/singularity-analysis-method-log' of git://trac.sagemath.org/sage into t/20040/asy/singularity-analysis-method-log
452c43bTrac #19944: `_singularity_analysis_` methods: more precise documentation
4cb5934Trac #20040: Merge #19944
8455dc2Trac #20040: `_singularity_analysis_` methods: more precise documentation
8bb9046Trac #20040: added myself to AUTHORS
40b6e2eTrac #20056: Rename AsymptoticRing.singularity_analysis to coefficients_generating_function

@dkrenn
Copy link
Contributor

dkrenn commented Feb 15, 2016

Reviewer: Daniel Krenn

@dkrenn
Copy link
Contributor

dkrenn commented Feb 15, 2016

comment:3

LGTM

@cheuberg

This comment has been minimized.

@cheuberg cheuberg changed the title Rename AsymptoticRing.singularity_analysis to coefficients_generating_function Rename AsymptoticRing.singularity_analysis to coefficients_of_generating_function Feb 15, 2016
@vbraun
Copy link
Member

vbraun commented Feb 16, 2016

Changed branch from u/cheuberg/asy/rename-singularity-analysis to 40b6e2e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants