-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GenericBackend: Add default implementation of add_variables
and add_linear_constraints
#20325
Comments
Dependencies: #20323 |
This comment has been minimized.
This comment has been minimized.
Last 10 new commits:
|
Commit: |
Author: Matthias Koeppe |
comment:5
Falilures in the patch bot |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:9
Needs review. |
This comment has been minimized.
This comment has been minimized.
comment:10
ping? |
comment:11
So you moved these implementations into the generic backend, basically? |
comment:12
Yes, and added a _test method and fixed a bug in the PPL method (which was tested by a wrong test). |
comment:13
ok, good. |
Reviewer: Dima Pasechnik |
comment:14
Thanks for reviewing, Dima. |
The backend methods
add_variables
andadd_linear_constraints
should have a default implementation inGenericBackend
, likeadd_linear_constraint_vector
.add_variables
can be taken from Gurobi and also removed from CVXOPT and InteractiveLP.add_linear_constraints
can be taken from COIN and also removed from CVXOPT and InteractiveLP.(The other backends have specific implementations of these methods; one supposes that they are faster, though this probably has not been tested.)
Since the removal of the copy-pasted functions from the backends would remove doctests, I mark this ticket as dependent on #20323.
The new tests revealed a bug in the PPL backend, which has been fixed.
Also, the CPLEX backend used to add variables in reverse order for no good reason; changed that.
Depends on #20323
CC: @dimpase @videlec @jdemeyer @fchapoton @nbruin
Component: numerical
Author: Matthias Koeppe
Branch/Commit:
40876ee
Reviewer: Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/20325
The text was updated successfully, but these errors were encountered: