Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MixedIntegerLinearProgram/MIPVariable: set_min, set_max are broken #20462

Closed
mkoeppe opened this issue Apr 19, 2016 · 10 comments
Closed

MixedIntegerLinearProgram/MIPVariable: set_min, set_max are broken #20462

mkoeppe opened this issue Apr 19, 2016 · 10 comments
Labels
c: linear programming c: numerical p: major / 3 t: bug
Milestone
sage-7.3

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 19, 2016

Here's a bug:

sage: p.<x,y> = MixedIntegerLinearProgram()
sage: x[0], y[0]
(x_0, x_1)
sage: p.set_max(x, 42)
sage: p.get_max(y[0])
42.0

The bug is in MIPVariable.set_min, .set_max, which calls back into the problem to change the bounds of all variables of the problem rather than just its components.

CC: @dimpase @videlec @jdemeyer @fchapoton @nbruin

Component: numerical

Author: Matthias Koeppe

Branch/Commit: 3a8b10d

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/20462
@mkoeppe mkoeppe added this to the sage-7.2 milestone Apr 19, 2016
@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 23, 2016

Author: Matthias Koeppe

@mkoeppe mkoeppe changed the title MixedIntegerLinearProgram/MIPVariable: get_min, set_min, get_max, set_max are broken MixedIntegerLinearProgram/MIPVariable: set_min, set_max are broken May 23, 2016
@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 23, 2016

Branch: u/mkoeppe/mixedintegerlinearprogram_mipvariable__get_min__set_min__get_max__set_max_are_broken

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 23, 2016

Commit: 3a8b10d

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 23, 2016

New commits:

3a8b10dFix #20462 - MIPVariable.set_min, set_max

@tscrim
Copy link
Collaborator

tscrim commented May 26, 2016

comment:8

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented May 26, 2016

Reviewer: Travis Scrimshaw

@tscrim tscrim modified the milestones: sage-7.2, sage-7.3 May 26, 2016
@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 26, 2016

comment:9

Thanks!

@vbraun
Copy link
Member

vbraun commented May 28, 2016

Changed branch from u/mkoeppe/mixedintegerlinearprogram_mipvariable__get_min__set_min__get_max__set_max_are_broken to 3a8b10d

@vbraun vbraun closed this as completed in fbe4f31 May 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: linear programming c: numerical p: major / 3 t: bug
Projects
None yet
Milestone
sage-7.3
Development

No branches or pull requests
3 participants
@vbraun @tscrim @mkoeppe