Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various autodoc unforking #20577

Closed
jdemeyer opened this issue May 9, 2016 · 11 comments
Closed

Various autodoc unforking #20577

jdemeyer opened this issue May 9, 2016 · 11 comments

Comments

@jdemeyer
Copy link

jdemeyer commented May 9, 2016

Move various changes from upstream Sphinx autodoc to Sage.

CC: @hivert @embray

Component: documentation

Author: Jeroen Demeyer

Branch/Commit: 7e74ee6

Reviewer: Marc Mezzarobba

Issue created by migration from https://trac.sagemath.org/ticket/20577

@jdemeyer jdemeyer added this to the sage-7.3 milestone May 9, 2016
@jdemeyer
Copy link
Author

jdemeyer commented May 9, 2016

Branch: u/jdemeyer/various_autodoc_unforking

@jdemeyer
Copy link
Author

jdemeyer commented May 9, 2016

New commits:

00d57a2Use formatargspec of Sphinx
a813230Python 3 changes in sage_autodoc
7a150db__builtin__ is builtins in Python 3
9355790Add get_sourcename() from upstream Sphinx
6076aacMove various changes from upstream Sphinx autodoc to Sage

@jdemeyer
Copy link
Author

jdemeyer commented May 9, 2016

Commit: 6076aac

@jdemeyer
Copy link
Author

Changed dependencies from #20572 to none

@dimpase
Copy link
Member

dimpase commented Sep 5, 2016

comment:4

there is meanwhile sphinx 1.4.6 out. Perhaps the delta is smaller w.r.t. it?

@dimpase dimpase modified the milestones: sage-7.3, sage-7.4 Sep 5, 2016
@johanrosenkilde
Copy link
Contributor

comment:6

I'm almost embarassed to bring it up since it happens to be my name, but I would have brought it up in any case: is it intentional that the AUTHORS block was removed? If I understand the legal reason for having those AUTHOR blocks at all, it seems that removing one without asking those on the list shouldn't be allowed.

For the record, I'm alright with removing my name if the entire block is removed.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 8, 2016

Changed commit from 6076aac to 7e74ee6

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 8, 2016

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

814153dAdd get_sourcename() from upstream Sphinx
7e74ee6Move various changes from upstream Sphinx autodoc to Sage

@jdemeyer
Copy link
Author

jdemeyer commented Sep 8, 2016

comment:8

Rebased and put back the authors.

@mezzarobba
Copy link
Member

Reviewer: Marc Mezzarobba

@vbraun
Copy link
Member

vbraun commented Sep 10, 2016

Changed branch from u/jdemeyer/various_autodoc_unforking to 7e74ee6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants