Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove code deprecated in #4492 #20665

Closed
novoselt opened this issue May 23, 2016 · 11 comments
Closed

Remove code deprecated in #4492 #20665

novoselt opened this issue May 23, 2016 · 11 comments
Labels
c: linear algebra p: major / 3 t: enhancement
Milestone
sage-9.2

Comments

@novoselt
Copy link
Member

Remove code deprecated in #4492. This is documentation proclaiming removal of code:
1a09d97#diff-84e5eb676ee10e60dfb12694d35fcdeeR1798
what exactly should be done with the flat input now? Should dimensions be mandatory?

Some kind of prehistoric deprecation ! Plus a few pep8 changes.

CC: @wjp @adeines @rbeezer @tscrim

Component: linear algebra

Author: Frédéric Chapoton

Branch/Commit: c4e2671

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/20665
@novoselt novoselt added this to the sage-7.3 milestone May 23, 2016
@fchapoton
Copy link
Contributor

Branch: u/chapoton/20665

@fchapoton
Copy link
Contributor

Author: Frédéric Chapoton

@fchapoton
Copy link
Contributor

New commits:

f120e46remove very old deprecation warning from ticket 4492

@fchapoton
Copy link
Contributor

Commit: f120e46

@fchapoton fchapoton modified the milestones: sage-7.3, sage-9.2 Jun 21, 2020
@fchapoton

This comment has been minimized.

Sign in to view
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 21, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

c4e2671some details in special matrices

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 21, 2020

Changed commit from f120e46 to c4e2671

@fchapoton
Copy link
Contributor

comment:4

and the bot is now green. Please review (easy one)

@tscrim
Copy link
Collaborator

tscrim commented Jun 22, 2020

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jun 22, 2020

comment:5

LGTM.

@vbraun
Copy link
Member

vbraun commented Jun 24, 2020

Changed branch from u/chapoton/20665 to c4e2671

@vbraun vbraun closed this as completed in 9ae4ffb Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: linear algebra p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.2
Development

No branches or pull requests
4 participants
@vbraun @tscrim @novoselt @fchapoton