Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PointConfiguration: Add plot method #20878

Closed
mkoeppe opened this issue Jun 24, 2016 · 14 comments
Closed

PointConfiguration: Add plot method #20878

mkoeppe opened this issue Jun 24, 2016 · 14 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 24, 2016

Triangulations of point configurations can be plotted;
but the configurations themselves can't.
This ticket adds a plot method to fix this.

CC: @vbraun @videlec @fchapoton @jdemeyer

Component: geometry

Author: Matthias Koeppe

Branch/Commit: 91b7086

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/20878

@mkoeppe mkoeppe added this to the sage-7.3 milestone Jun 24, 2016
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 25, 2016

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 25, 2016

New commits:

4ffc1e1PointConfiguration: Add plot method

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 25, 2016

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 25, 2016

Commit: 4ffc1e1

@tscrim
Copy link
Collaborator

tscrim commented Jun 25, 2016

comment:3

It would be good to add the plot to the documentation using the .. PLOT:: directive (see, e.g., knots/link.py).

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 25, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

77a1eafAdd some .. PLOT directives

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 25, 2016

Changed commit from 4ffc1e1 to 77a1eaf

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 25, 2016

comment:5

Replying to @tscrim:

It would be good to add the plot to the documentation using the .. PLOT:: directive (see, e.g., knots/link.py).

OK, I have added a few.

@tscrim
Copy link
Collaborator

tscrim commented Jun 25, 2016

comment:6

If you could also add a plot in the plot() method, then you can set a positive review on my behalf. Thanks.

@tscrim
Copy link
Collaborator

tscrim commented Jun 25, 2016

Reviewer: Travis Scrimshaw

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 25, 2016

Changed commit from 77a1eaf to 91b7086

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 25, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

91b7086PointConfiguration.plot: Add .. PLOT:: directive

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 25, 2016

comment:8

Thanks for reviewing, Travis!

@vbraun
Copy link
Member

vbraun commented Jun 26, 2016

Changed branch from u/mkoeppe/pointconfiguration__add_plot_method to 91b7086

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants