Polyhedron.integral_points() fails for non-rational polytopes

[mkoeppe]

    sage: P = Polyhedron(vertices=((0, 0), (17,3))) + 1/1000*polytopes.regular_polygon(5)
    sage: P.integral_points()
    TypeError: int() argument must be a string or a number, not 'AlgebraicReal'

(This is an irrational polytope with a small bounding box. Sage should be able to enumerate it easily using the rectangular_box_points method.)

CC: @tscrim @novoselt @dimpase @videlec @vbraun @jdemeyer

Component: geometry

Author: Travis Scrimshaw

Branch/Commit: 35eca5a

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/21037

[tscrim]

Author: Travis Scrimshaw

[tscrim]

Commit: b09bea7

[tscrim]

Branch: public/geometry/integral_points/non_rational_points-21037

[tscrim]

comment:1

Just not enough error catching.

---

New commits:

b09bea7

Fixing integral points for non-rational points.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

35eca5a

Fixing integral points for non-rational points.

[sagetrac-git]

Changed commit from b09bea7 to 35eca5a

[mkoeppe]

Reviewer: Matthias Koeppe

[mkoeppe]

comment:4

Thanks for fixing this!
I've moved the other item to #21041.

[vbraun]

comment:5

sage -t --long src/sage/geometry/integral_points.pyx
**********************************************************************
File "src/sage/geometry/integral_points.pyx", line 539, in sage.geometry.integral_points.?
Failed example:
    alarm(0.5); P.integral_points()
Expected:
    Traceback (most recent call last):
    ...
    AlarmInterrupt
Got:
    Exception cysignals.signals.AlarmInterrupt: AlarmInterrupt() in 'sage.geometry.integral_points.InequalityCollection.are_satisfied' ignored
    ((-5, -8, -10, -15, -12, -9, -6, -3),
     (-3, -5, -6, -9, -7, -5, -3, -1),
     (-1, -3, -3, -5, -4, -3, -2, -1),
     (-1, -2, -2, -3, -2, -1, 0, 0))
**********************************************************************
1 item had failures:
   1 of  51 in sage.geometry.integral_points.?
    [170 tests, 1 failure, 51.33 s]

[tscrim]

comment:6

IIRC, I also got that error sporadically when I was testing #18029 as well, but I don't seem to get that on develop. Jeroen, any ideas?

[vbraun]

comment:7

yes, the error is coming from #18029

[vbraun]

Changed branch from public/geometry/integral_points/non_rational_points-21037 to 35eca5a