Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the maxima interface doesn't recognize a syntax error #2109

Closed
mwhansen opened this issue Feb 8, 2008 · 7 comments
Closed

the maxima interface doesn't recognize a syntax error #2109

mwhansen opened this issue Feb 8, 2008 · 7 comments

Comments

@mwhansen
Copy link
Contributor

mwhansen commented Feb 8, 2008

sage: maxima.eval('sage0: x == x;')
display2d : false; 
(%o2) false

0; 
(%o4) 0

It hangs there. If doing the same thing in Maxima, we get the following results:

(%i1) sage0: x==x;
Incorrect syntax: = is not a prefix operator
sage0: x==
        ^

Component: interfaces

Author: Mike Hansen

Reviewer: Karl-Dieter Crisman

Merged: sage-4.3.1.rc1

Issue created by migration from https://trac.sagemath.org/ticket/2109

@aghitza
Copy link

aghitza commented Aug 24, 2009

comment:1

Here is what happens in sage-4.1.1:

sage: maxima.eval('sage0: x == x;')
'x'

@kcrisman
Copy link
Member

comment:2

So at least it doesn't hang anymore. I will change the summary.

@kcrisman kcrisman changed the title the maxima interface doesn't recognize a syntax error (and then hangs) the maxima interface doesn't recognize a syntax error Dec 17, 2009
@mwhansen
Copy link
Contributor Author

Attachment: trac_2109.patch.gz

@mwhansen
Copy link
Contributor Author

Author: Mike Hansen

@kcrisman
Copy link
Member

Reviewer: Karl-Dieter Crisman

@kcrisman
Copy link
Member

comment:4

Passes relevant tests, catches several different types of incorrect input errors, and helped me learn a little more about pexpect. Positive review, and thanks!

Unfortunately, it doesn't catch when someone does something like this, but I'm not sure this is really an "error", as it's intended that Maxima can handle this sort of thing... yet it could easily come as a result of an error by the user. Oh well.

integrate(f,
x,1,
2)

@rlmill
Copy link
Mannequin

rlmill mannequin commented Jan 19, 2010

Merged: sage-4.3.1.rc1

@rlmill rlmill mannequin removed the s: positive review label Jan 19, 2010
@rlmill rlmill mannequin closed this as completed Jan 19, 2010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants