Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ARCHFLAGS environment variable - for Perl modules #21175

Closed
mkoeppe opened this issue Aug 5, 2016 · 20 comments
Closed

Set ARCHFLAGS environment variable - for Perl modules #21175

mkoeppe opened this issue Aug 5, 2016 · 20 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 5, 2016

To make installing Perl modules easier on Mac OS X, we should set the ARCHFLAGS environment variable. This is to make sure that the output of perl -MExtUtils::Embed -e ldopts and perl -MExtUtils::Embed -e ccflags (picked up from system perl) do not contain -arch flags incompatible with our gcc.

This simplifies perl_term_readline_gnu (#20894), polymake (#20892), and makes installing pypolymake (#21170) as a pip package possible.

CC: @videlec @jdemeyer @embray @vbraun @sagetrac-tmonteil @dimpase @kcrisman

Component: build

Author: Matthias Koeppe

Branch: 78f2cfa

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/21175

@mkoeppe mkoeppe added this to the sage-7.4 milestone Aug 5, 2016
@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 5, 2016

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 5, 2016

Commit: 4c23c4e

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 5, 2016

New commits:

01abf17Set ARCHFLAGS on Darwin
4c23c4eperl_term_readline_gnu: Don't set ARCHFLAGS, use global setting

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 5, 2016

Author: Matthias Koeppe

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 18, 2016

Changed commit from 4c23c4e to 4fce479

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 18, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

af44810Merge tag '7.4.beta1' into t/21175/set_archflags_environment_variable___for_perl_modules
4fce479polymake: Don't set ARCHFLAGS, use global setting

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 18, 2016

comment:7

Needs review.

@dimpase
Copy link
Member

dimpase commented Aug 26, 2016

comment:8

It looks OK on Linux; must it be tested on OSX too?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 26, 2016

comment:9

I have tested it on both platforms.

@dimpase
Copy link
Member

dimpase commented Aug 26, 2016

comment:10

put in this, and then tried to install polymake on OSX, and got

[polymake-3.0r2] checking fink installation ... The Fink package system is a mandatory prerequisite to build and use polymake under MacOS.
[polymake-3.0r2] Please refer to http://www.polymake.org/doku.php/mac for details and installation instructions.
[polymake-3.0r2] If you already have Fink installed at a non-standard location, please specify it using option --with-fink
[polymake-3.0r2] Error configuring Polymake

Really? Fink?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 26, 2016

Changed commit from 4fce479 to 78f2cfa

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 26, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

78f2cfaRestore --without-fink that was lost

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 26, 2016

comment:12

Thanks for catching this -- I killed the --without-fink by accident. Should work now.

@dimpase
Copy link
Member

dimpase commented Aug 27, 2016

comment:13

OK, looks good now.

@vbraun
Copy link
Member

vbraun commented Aug 27, 2016

comment:14

Reviewer name

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 28, 2016

Reviewer: Dima Pasechnik

@vbraun
Copy link
Member

vbraun commented Aug 30, 2016

@vbraun vbraun closed this as completed in 4dcbec2 Aug 30, 2016
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 9, 2020

comment:17

Follow-up in #29408

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 9, 2020

Changed commit from 78f2cfa to none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants