Install src/bin scripts by sagelib's setup.py, not make

[mkoeppe]

This ticket cleans up how the contents of src/bin are installed. One of its goals is to make the sagelib installation done by src/setup.py self-contained regarding the scripts that it needs at runtime.

Previous tickets moved some of the scripts to build/bin (no longer installed in SAGE_LOCAL).

In follow-up tickets, src/bin could be cleaned up more.

• See the list of files added on this ticket to src/setup.py for beginnings of a categorization.
• Install sage-env-config as part of sage_conf #29850: Install src/bin/sage-env-config as part of sage_conf
• Install sage_setup with setuptools as a prerequisite for building/installing sagelib #29847: Install sage_setup with setuptools as a prerequisite for building/installing sagelib, install sage-the-distribution scripts as "scripts"

Depends on #29111

CC: @jdemeyer @vbraun @embray @isuruf @jhpalmieri @kiwifb @kcrisman @orlitzky @antonio-rojas @dimpase

Component: build

Author: Matthias Koeppe

Branch/Commit: 19d7f67

Reviewer: John Palmieri, François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/21559

[embray]

comment:2

+1

Also sage-pip-install of #21441, but I might wait until that ticket is merged first, then move that script along with the others.

[jdemeyer]

comment:3

Replying to @embray:

+1

Also sage-pip-install of #21441

I already moved that in #21441 (which still needs review by the way).

[videlec]

comment:6

update milestone 8.3 -> 8.4

[embray]

comment:8

As the Sage-8.8 release milestone is pending, we should delete the sage-8.8 milestone for tickets that are not actively being worked on or that still require significant work to move forward. If you feel that this ticket should be included in the next Sage release at the soonest please set its milestone to the next release milestone (sage-8.9).

[mkoeppe]

Branch: u/mkoeppe/change-src-bin-installation

[mkoeppe]

Commit: 428ea11

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

New commits:

1a54a80	Move src/bin/testc*.sh to build/bin/, delete src/bin/sage-README-osx.txt
428ea11	Install src/bin/* by setup.py [scripts] instead of by build/make/deps

[sagetrac-git]

Changed commit from 428ea11 to 1b3c860

[sagetrac-git]

Changed commit from 831cc09 to e3eca85

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

a56dc35	Merge tag '9.2.beta1' into t/29702/public/move_all_code_from_src_setup_py__src_fpickle_setup_py_to_sage_setup
e3eca85	Merge branch 'public/move_all_code_from_src_setup_py__src_fpickle_setup_py_to_sage_setup' of git://trac.sagemath.org/sage into t/21559/change-src-bin-installation

[jhpalmieri]

comment:60

I run into problems unless I make this change:

diff --git a/src/setup.py b/src/setup.py
index 9970525cf9..85a32a5962 100755
--- a/src/setup.py
+++ b/src/setup.py
@@ -162,7 +162,6 @@ code = setup(name = 'sage',
                  'bin/sage-rebaseall.sh',
                  'bin/sage-rst2sws',
                  'bin/sage-rst2txt',
-                 'bin/sage-rsyncdist',
                  'bin/sage-run',
                  'bin/sage-run-cython',
                  'bin/sage-startuptime.py',

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

7d29141

src/setup.py: Do not install removed script sage-rsyncdist

[sagetrac-git]

Changed commit from e3eca85 to 7d29141

[mkoeppe]

comment:63

Needs review

[jhpalmieri]

comment:64

Looks okay to me.

[jhpalmieri]

Reviewer: John Palmieri, François Bissey

[mkoeppe]

comment:65

Thanks!

[sagetrac-git]

Changed commit from 7d29141 to c5f7f2f

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

c5f7f2f

Merge tag '9.2.beta3' into t/21559/change-src-bin-installation

[sagetrac-git]

Changed commit from c5f7f2f to 19d7f67

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

3953671	Merge tag '9.2.beta4' into t/29111/specify_a_subset_of_sage_command_line_options_that_are_supported_by_sagelib___rather_than_sage_the_distribution
19d7f67	Merge branch 't/29111/specify_a_subset_of_sage_command_line_options_that_are_supported_by_sagelib___rather_than_sage_the_distribution' into t/21559/change-src-bin-installation

[mkoeppe]

Changed dependencies from #29702, #29111, #29920 to #29111

[vbraun]

Changed branch from u/mkoeppe/change-src-bin-installation to 19d7f67