Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify qhull spkg patch #21572

Closed
mkoeppe opened this issue Sep 23, 2016 · 15 comments
Closed

Simplify qhull spkg patch #21572

mkoeppe opened this issue Sep 23, 2016 · 15 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Sep 23, 2016

This is for #21534.

The ticket also changes "make -j1" to "$MAKE".
The "-j1" should be unnecessary. The Makefile.patch purports to fix the dependency problems of the original Makefile; and a parallel build works for me with it.

CC: @videlec @jdemeyer @dimpase

Component: packages: optional

Author: Matthias Koeppe

Branch/Commit: 808f960

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/21572

@mkoeppe mkoeppe added this to the sage-7.4 milestone Sep 23, 2016
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 23, 2016

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 23, 2016

Commit: ac49e35

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 23, 2016

New commits:

19360c0Don't patch DESTDIR in Makefile, just pass it as an argument
ac49e35Use make -j8, remove -j1 for building

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 23, 2016

Author: Matthias Koeppe

@jdemeyer
Copy link

Reviewer: Jeroen Demeyer

@jdemeyer jdemeyer changed the title Simplify qhull spkg patch and use SAGE_LOCAL instead of SAGE_ROOT/local Simplify qhull spkg patch Sep 25, 2016
@jdemeyer
Copy link

comment:6

Fixed commit message of last commit


New commits:

30bf5d5Use $MAKE, remove -j1 for building

@jdemeyer
Copy link

Changed commit from ac49e35 to 30bf5d5

@jdemeyer
Copy link

comment:7

I do get failures with a parallel build:

============================================
== make qtest ==============================
============================================
== Otherwise if user_eg fails to link, switch to -lqhullstatic_r
bin/qconvex
== Sun Sep 25 09:26:10 CEST 2016

============================================
QH6075 == Test non-reentrant qset.c with mem.c ====
qhull input error: short input file.  Did not find dimension and number of points

While executing:  | qconvex
Options selected for Qhull 2015.2 2016/01/18:
  run-id 511880916
Makefile:323: recipe for target 'qconvex-prompt' failed
make: *** [qconvex-prompt] Error 1
make: *** Waiting for unfinished jobs....

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 25, 2016

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

808f960Use $MAKE instead of make

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Sep 25, 2016

Changed commit from 30bf5d5 to 808f960

@jdemeyer
Copy link

comment:9

Put back the -j1 option. Please check and then set this to positive_review if you agree.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 25, 2016

comment:10

Thanks for testing this thoroughly.

@vbraun
Copy link
Member

vbraun commented Oct 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants