Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to pynac-0.7.4 #22219

Closed
rwst opened this issue Jan 20, 2017 · 17 comments
Closed

Upgrade to pynac-0.7.4 #22219

rwst opened this issue Jan 20, 2017 · 17 comments

Comments

@rwst
Copy link

rwst commented Jan 20, 2017

From pynac-0.7.4 Changelog:

With this ticket we also finally turn on Giac support in Pynac (used for GCD) again (#21885).

https://github.com/pynac/pynac/releases/download/pynac-0.7.4/pynac-0.7.4.tar.bz2

Component: packages: standard

Author: Ralf Stephan

Branch/Commit: 57c7bce

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/22219

@rwst rwst added this to the sage-7.6 milestone Jan 20, 2017
@rwst
Copy link
Author

rwst commented Jan 20, 2017

Branch: u/rws/upgrade_to_pynac_0_7_4

@rwst
Copy link
Author

rwst commented Jan 20, 2017

New commits:

11951c822219: pkg version/chksum
91973f122219: giac usage is GO
a178a7522219: doctest fixes

@rwst
Copy link
Author

rwst commented Jan 20, 2017

Commit: a178a75

@rwst
Copy link
Author

rwst commented Jan 20, 2017

Author: Ralf Stephan

@jpflori
Copy link

jpflori commented Jan 31, 2017

comment:3

I get a bunch of errors when running tests on a POWER7:

sage: y = var('y')
sage: g = x + y/(x + 2); g
x + y/(x + 2)
sage: g
x + y/(x + 2)
sage: g.numerator()
---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
<ipython-input-4-7f8c42e112c2> in <module>()
----> 1 g.numerator()

/home/jpflori/sage.git/src/sage/symbolic/expression.pyx in sage.symbolic.expression.Expression.numerator (/home/jpflori/sage.git/src/build/cythonized/sage/symbolic/expression.cpp:45767)()
   8608         cdef GEx oper, power
   8609         if normalize:
-> 8610             return new_Expression_from_GEx(self._parent, self._gobj.numer())
   8611         elif is_a_mul(self._gobj):
   8612             for i from 0 <= i < self._gobj.nops():

RuntimeError: Exponent overflow Error: Bad Argument Value

@rwst
Copy link
Author

rwst commented Jan 31, 2017

comment:4

Could you please do the following: start sage -gdb, hit Ctrl-Z to get the gdb prompt, input catch throw then give c<Enter> until you get back to the Sage prompt. Now on error you should be thrown directly down to gdb. Now I would be interested in a backtrace that you can get with bt. I don't need the full list, please give me just the C++ part, i.e. everything until you see the Py... functions.

@jpflori
Copy link

jpflori commented Jan 31, 2017

comment:5

Here you go:

#0  0x00003fffac10ae54 in .__cxa_throw () from /lib64/libstdc++.so.6
#1  0x00003ffb20b99b38 in giac::undeferr (
    s="Exponent overflow Error: Bad Argument Value") at gen.cc:445
#2  0x00003ffb20b99f84 in giac::gensizeerr (s=...) at gen.cc:485
#3  0x00003ffb20c0110c in giac::pow (base=..., exponent=<optimized out>)
    at gen.cc:7096
#4  0x00003ffb20472644 in giac::giac_gcd_modular_algo1 (p=..., q=..., d=...)
    at modpoly.cc:7309
#5  0x00003ffb2047af4c in giac::gcd_modular_algo1 (p=..., q=..., d=..., 
    compute_cof=<optimized out>) at modpoly.cc:7675
#6  0x00003ffb201decc4 in giac::gcd_modular_algo (p=..., q=..., d=..., 
    compute_cof=<optimized out>) at gausspol.cc:3513
#7  0x00003ffb2047bc38 in giac::gcd_modular (p_orig=..., q_orig=..., pgcd=..., 
    pcofactor=..., qcofactor=..., compute_cofactors=<optimized out>)
    at modpoly.cc:2878
#8  0x00003ffb201bcb28 in giac::gcdheu (p_orig=..., 
    p_deg=std::vector of length 1, capacity 1 = {...}, q_orig=..., 
    q_deg=std::vector of length 1, capacity 1 = {...}, p_simp=..., 
    np_simp=..., q_simp=..., nq_simp=..., d=..., d_content=..., 
    skip_test=skip_test@entry=false, 
    compute_cofactors=compute_cofactors@entry=false) at gausspol.cc:3920
#9  0x00003ffb201c256c in giac::gcd (p=..., q=..., d=...) at gausspol.cc:4675
#10 0x00003ffb201c1eec in giac::gcd (p=..., q=..., d=...) at gausspol.cc:4657
#11 0x00003ffb201c2c9c in giac::gcd (p=..., q=...) at gausspol.cc:4693
#12 0x00003ffb201c7988 in giac::has_constant_variables_gcd (p=..., q=..., 
    d=...) at gausspol.cc:3756
#13 0x00003ffb201c2418 in giac::gcd (p=..., q=..., d=...) at gausspol.cc:4669
#14 0x00003ffb210d1b0c in GiNaC::gcdpoly (a=..., b=..., ca=0x3fffffff9b18, 
    cb=0x3fffffff9b10, check_args=<optimized out>) at mpoly-giac.cpp:392
#15 0x00003ffb21100a28 in GiNaC::frac_cancel (n=..., d=...) at normal.cpp:405
#16 0x00003ffb211016f0 in GiNaC::add::normal (this=<optimized out>, repl=..., 
    rev_lookup=..., level=<optimized out>, options=<optimized out>)
    at normal.cpp:491
#17 0x00003ffb210f9cec in GiNaC::ex::numer (this=<optimized out>)
    at normal.cpp:646
...

@jpflori
Copy link

jpflori commented Jan 31, 2017

comment:6

Which looks very giac related.
I think I got other giac errors (without going through pynac), I'll have to check.

@jpflori
Copy link

jpflori commented Jan 31, 2017

comment:7

It might be http://xcas.e.ujf-grenoble.fr/XCAS/viewtopic.php?f=19&t=1723 so completely pynac unrelated.

@jpflori
Copy link

jpflori commented Jan 31, 2017

comment:8

And I guess it also means the dependencies file should mention giac.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 31, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

c7eb7ffMerge branch 'develop' into t/22219/upgrade_to_pynac_0_7_4
57c7bce22219: giac dependency

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 31, 2017

Changed commit from a178a75 to 57c7bce

@rwst
Copy link
Author

rwst commented Jan 31, 2017

comment:10

Replying to @jpflori:

And I guess it also means the dependencies file should mention giac.

Yes, I always forget that.

@dkrenn

This comment has been minimized.

@dkrenn
Copy link
Contributor

dkrenn commented Feb 4, 2017

comment:12

FYI, Everything seem to work fine on Linux Mint 17.3.

@vbraun
Copy link
Member

vbraun commented Feb 5, 2017

Reviewer: Volker Braun

@vbraun
Copy link
Member

vbraun commented Feb 6, 2017

Changed branch from u/rws/upgrade_to_pynac_0_7_4 to 57c7bce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants