Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement duality of faces for reflexive polytopes #22275

Closed
novoselt opened this issue Jan 29, 2017 · 9 comments
Closed

Implement duality of faces for reflexive polytopes #22275

novoselt opened this issue Jan 29, 2017 · 9 comments
Labels
c: geometry p: major / 3 t: enhancement
Milestone
sage-7.6

Comments

@novoselt
Copy link
Member

It was "secretly" implemented in the old code removed in #22122 by order of faces and while it was not documented in Sage, it was dissipated in some worksheets and papers.

Depends on #22122

CC: @saraedum

Component: geometry

Author: Andrey Novoseltsev

Branch/Commit: 4109827

Reviewer: Julian Rüth

Issue created by migration from https://trac.sagemath.org/ticket/22275
@novoselt novoselt added this to the sage-7.6 milestone Jan 29, 2017
@novoselt
Copy link
Member Author

Branch: u/novoselt/22275

@novoselt
Copy link
Member Author

comment:2

Julian, can you take a look at a short follow up for #22122?

New commits:

4599dccRemove old-style faces of lattice polytopes
5c97bbdMerge #22122 into #22275
77616f8Implement duality of faces for reflexive polytopes

@novoselt
Copy link
Member Author

Commit: 77616f8

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 29, 2017

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

4109827Implement duality of faces for reflexive polytopes

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 29, 2017

Changed commit from 77616f8 to 4109827

@novoselt
Copy link
Member Author

comment:4

Managed to miss blank line somehow.

@saraedum
Copy link
Member

Reviewer: Julian Rüth

@novoselt
Copy link
Member Author

comment:6

Thank you!

@vbraun
Copy link
Member

vbraun commented Feb 3, 2017

Changed branch from u/novoselt/22275 to 4109827

@vbraun vbraun closed this as completed in 48a6610 Feb 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: geometry p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-7.6
Development

No branches or pull requests
3 participants
@saraedum @vbraun @novoselt