Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate/remove sage/geometry/polytope.py #22469

Closed
sagetrac-tmonteil mannequin opened this issue Feb 28, 2017 · 9 comments
Closed

Deprecate/remove sage/geometry/polytope.py #22469

sagetrac-tmonteil mannequin opened this issue Feb 28, 2017 · 9 comments
Labels
c: interfaces p: major / 3 t: bug
Milestone
sage-7.6

Comments

@sagetrac-tmonteil
Copy link
Mannequin

sagetrac-tmonteil mannequin commented Feb 28, 2017

This is a both old and broken interface to an old version of polymake.

Note that ticket #22452 aims to build a pexpect interface to the pypolymake package, and #21170 aims at providing pypolymake cython interface.

CC: @jplab

Component: interfaces

Keywords: days84

Author: Jean-Philippe Labbé

Branch/Commit: b6d66de

Reviewer: Thierry Monteil

Issue created by migration from https://trac.sagemath.org/ticket/22469
@sagetrac-tmonteil sagetrac-tmonteil mannequin added this to the sage-7.6 milestone Feb 28, 2017
@jplab
Copy link

jplab commented Feb 28, 2017

Branch: u/jipilab/22469

@jplab
Copy link

jplab commented Feb 28, 2017

Commit: b6d66de

@jplab
Copy link

jplab commented Feb 28, 2017

New commits:

b6d66deRemoved the old interface of polymake

@jplab
Copy link

jplab commented Feb 28, 2017

Author: Jean-Philippe Labbé

@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented Feb 28, 2017

Reviewer: Thierry Monteil

@sagetrac-tmonteil
Copy link
Mannequin Author

sagetrac-tmonteil mannequin commented Feb 28, 2017

comment:4

For the record, there is a consensus here at days84 to just remove the file without deprecation period since this module is currently boken and unusable anyway.

@jplab

This comment has been minimized.

Sign in to view
@sagetrac-tmonteil

This comment has been minimized.

Sign in to view
@vbraun
Copy link
Member

vbraun commented Mar 2, 2017

Changed branch from u/jipilab/22469 to b6d66de

@vbraun vbraun closed this as completed in c1f1a71 Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: interfaces p: major / 3 t: bug
Projects
None yet
Milestone
sage-7.6
Development

No branches or pull requests
2 participants
@vbraun @jplab