-
-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate the old .field() method from polyhedron class #22551
Comments
Branch: u/jipilab/deprecate_field |
New commits:
|
Commit: |
Changed branch from u/jipilab/deprecate_field to none |
Changed commit from |
comment:3
In |
New commits:
|
Branch: u/jipilab/deprecate_field |
Commit: |
comment:5
@@ -2032,8 +2032,6 @@ class Polyhedron_base(Element):
"""
return self.parent().base_ring()
- field = base_ring
-
@cached_method
def center(self): No deprecation here? |
Reviewer: Vincent Delecroix |
comment:7
Replying to @videlec:
Hmm. Right. I confused the keyword with the method here. I will add a deprecation warning. |
comment:8
Replying to @videlec:
Since it is in a nested function, I removed the deprecation warning. This was intended merely to make the nomenclature about base ring consistent across the geometry component... |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:11
I can not reproduce the timeout from the patchbot. |
Changed branch from u/jipilab/deprecate_field to |
Ticket #11634 made the ppl library be the default backend for the
Polyhedron class
.Currently, Polyhedron objects still have a
.field()
method which is ill-named and since #11634 out-dated.This ticket deprecates this method.
CC: @mo271 @mkoeppe @videlec @sagetrac-tmonteil @fchapoton
Component: geometry
Keywords: days84
Author: Jean-Philippe Labbé
Branch/Commit:
6291dd1
Reviewer: Vincent Delecroix
Issue created by migration from https://trac.sagemath.org/ticket/22551
The text was updated successfully, but these errors were encountered: