-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write custom create_extension() for Cython #22554
Comments
Commit: |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:11
I can't really comment on this patch, but I've successfully built sage with it on my Mac with homebrew (which provides gfortran, so the Sage gcc is not installed), using Apple's "gcc" (clang) |
comment:12
Replying to @mkoeppe:
Just to be clear: I assume you mean with |
comment:13
Turns out I used a different "feature" of the build system. I had configured using |
Changed upstream from Reported upstream. Developers acknowledge bug. to Fixed upstream, but not in a stable release. |
comment:15
What does "This requires an upstream patch" mean? That it should be applied to the upstream tarball? (in fact one does not seem to need it to be applied to Sage, so this probably needs to be clarified in the ticket description) |
comment:16
Replying to @dimpase:
That the patch from the linked github pull request should be applied to the Cython sources. In this case, the patch is added as |
Reviewer: Dima Pasechnik |
Changed branch from u/jdemeyer/use_create_extension___from_cython to |
Implement a custom
create_extension()
function for Cython. This new function does some things which were done insetup.py
in different places, but now have one dedicated place. It should also fix the problem where-std=c99
is used for a C++ extension, which is an error for Clang. Also duplicate flags (like-msse -mmse
) are removed.This requires an upstream patch cython/cython#466
Upstream: Fixed upstream, but not in a stable release.
Component: build
Author: Jeroen Demeyer
Branch/Commit:
0c0c603
Reviewer: Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/22554
The text was updated successfully, but these errors were encountered: