Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fold farey.pxd into farey_symbol.pyx #22662

Closed
jdemeyer opened this issue Mar 21, 2017 · 11 comments
Closed

Fold farey.pxd into farey_symbol.pyx #22662

jdemeyer opened this issue Mar 21, 2017 · 11 comments
Labels
c: cython p: major / 3 t: enhancement
Milestone
sage-8.0

Comments

@jdemeyer
Copy link

Unlike other .pxd files, the file farey.pxd is not meant as public header. For this reason, we move its contents to the file farey_symbol.pyx, which is the only place where it is used.

We also fix a typo __deallocpp__ causing a memory leak.

CC: @embray

Component: cython

Author: Jeroen Demeyer

Branch/Commit: 8e5db1e

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/22662
@jdemeyer jdemeyer added this to the sage-8.0 milestone Mar 21, 2017
@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer
Copy link
Author

Branch: u/jdemeyer/ticket/22662

@jdemeyer
Copy link
Author

New commits:

1dd5771Fold farey.pxd into farey_symbol.pyx

@jdemeyer
Copy link
Author

Commit: 1dd5771

@fchapoton
Copy link
Contributor

comment:4
sage -t --long src/sage_setup/find.py  # 1 doctest failed

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 28, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

8e5db1eChange test

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 28, 2017

Changed commit from 1dd5771 to 8e5db1e

@jdemeyer
Copy link
Author

comment:8

Replying to @fchapoton:

sage -t --long src/sage_setup/find.py  # 1 doctest failed

Fixed, patchbot looks good now.

@fchapoton
Copy link
Contributor

comment:9

ok, let it be

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@vbraun
Copy link
Member

vbraun commented Apr 6, 2017

Changed branch from u/jdemeyer/ticket/22662 to 8e5db1e

@vbraun vbraun closed this as completed in 6f6a086 Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: cython p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.0
Development

No branches or pull requests
3 participants
@vbraun @jdemeyer @fchapoton