Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't export SAGE_SCRIPTS_DIR #22736

Closed
jdemeyer opened this issue Apr 1, 2017 · 6 comments
Closed

Don't export SAGE_SCRIPTS_DIR #22736

jdemeyer opened this issue Apr 1, 2017 · 6 comments
Labels
c: scripts p: trivial / 5 t: enhancement
Milestone
sage-8.0

Comments

@jdemeyer
Copy link

jdemeyer commented Apr 1, 2017

The variable SAGE_SCRIPTS_DIR is only meant to be used in sage-env to find sage-env-config for example. It is not meant to be used externally, so it should not be exported.

Depends on #21479

CC: @mkoeppe @tobihan

Component: scripts

Author: Jeroen Demeyer

Branch/Commit: ae90cc9

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/22736
@jdemeyer jdemeyer added this to the sage-8.0 milestone Apr 1, 2017
@jdemeyer
Copy link
Author

jdemeyer commented Apr 1, 2017

Dependencies: #21479

@jdemeyer
Copy link
Author

jdemeyer commented Apr 1, 2017

Branch: u/jdemeyer/don_t_export_sage_scripts_dir

@jdemeyer
Copy link
Author

jdemeyer commented Apr 1, 2017

Commit: ae90cc9

@jdemeyer
Copy link
Author

jdemeyer commented Apr 1, 2017

Last 10 new commits:

f624c95bootstrap: Don't use sage-env, set PATH directly
2dccfb0Restore lost comment
2aafa6fIndentation fix
4eeb130Install sage-env-config, not sage-env-config.in
8965a08Use SAGE_SCRIPTS_DIR to source sage-env-config
7b4dfbfSource sage-env but silence errors
44110ceLet "make install" build Sage
7d2595cRevert unneeded changes
1e98d9cHardcode path to sage-download-file
ae90cc9Don't export SAGE_SCRIPTS_DIR

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 1, 2017

Reviewer: Matthias Koeppe

@vbraun
Copy link
Member

vbraun commented Apr 5, 2017

Changed branch from u/jdemeyer/don_t_export_sage_scripts_dir to ae90cc9

@vbraun vbraun closed this as completed in fab799b Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: scripts p: trivial / 5 t: enhancement
Projects
None yet
Milestone
sage-8.0
Development

No branches or pull requests
3 participants
@vbraun @jdemeyer @mkoeppe