-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes to lazy imports #22755
Comments
Branch: u/jdemeyer/ticket/22755 |
Commit: |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Changed dependencies from #22753 to none |
Branch pushed to git repo; I updated commit sha1. New commits:
|
This comment has been minimized.
This comment has been minimized.
comment:10
You expect the following traceback to be accepted by doctests?
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:12
Replying to @videlec:
Apparently yes (see patchbot) :-) Anyway, I fixed it. |
comment:13
Weird patchbot failure on quasar! Do you think it is related to your ticket? |
comment:14
Replying to @videlec:
Almost certainly not. |
comment:16
The most recent patchbot run passes all tests. |
comment:17
The documentation of the NOTE: though it is deprecated |
comment:18
Why stuff from |
comment:19
As I tried to explain in the ticket description, it was lazily importing a lazy import. |
comment:20
Ping? |
Reviewer: Vincent Delecroix |
comment:22
done! |
Changed branch from u/jdemeyer/ticket/22755 to |
Assorted fixes to lazy imports:
Drop support for
lazy_import(overwrite=False)
which was used only in one place in a dubious way to implement a 2-level lazy import (a lazy import being lazily imported).More optimal code for binary operations like
__add__
by avoiding theoperator
module.Move the code to replace a lazy import in a class namespace from
_get_object()
to__get__
.Partially inline
_get_object()
with a newcdef inline
function for the case that the object has been initialized.A lazy import without
at_startup
being imported at startup is now an error (it used to just print a message, which is less useful than an error traceback).Implement matmul (pointless in Python 2, but useful for Python 3).
Clean up the function
lazy_import
a bit.Component: misc
Author: Jeroen Demeyer
Branch/Commit:
4dda1ae
Reviewer: Vincent Delecroix
Issue created by migration from https://trac.sagemath.org/ticket/22755
The text was updated successfully, but these errors were encountered: