Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Python 2 build on Cygwin #23059

Closed
embray opened this issue May 23, 2017 · 9 comments
Closed

Fix Python 2 build on Cygwin #23059

embray opened this issue May 23, 2017 · 9 comments
Labels
c: porting: cygwin p: blocker / 1 t: bug
Milestone
sage-8.0

Comments

@embray
Copy link
Contributor

embray commented May 23, 2017

This commit broke the build of Python 2 on Cygwin by moving the definition of the PYTHON_VERSION variable used for the Cygwin install as well as OSX.

I didn't notice before since I was just doing incremental builds.

Component: porting: Cygwin

Author: Erik Bray

Branch/Commit: 609393a

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/23059
@embray embray added this to the sage-8.0 milestone May 23, 2017
@embray
Copy link
Contributor Author

embray commented May 23, 2017

Branch: u/embray/cygwin/ticket-23059

@embray
Copy link
Contributor Author

embray commented May 23, 2017

Author: Erik Bray

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 23, 2017

Commit: 609393a

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 23, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

609393aRoll back accidental change from dc46ea2dfa97be79d7ef8ddbe9130d4c717acc3d that broke build of Python 2 on Cygwin.

@tscrim
Copy link
Collaborator

tscrim commented May 24, 2017

comment:3

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented May 24, 2017

Reviewer: Travis Scrimshaw

@jhpalmieri
Copy link
Member

comment:4

Sorry, that was a silly mistake on my part.

@embray
Copy link
Contributor Author

embray commented May 26, 2017

comment:5

No problem!

@vbraun
Copy link
Member

vbraun commented May 26, 2017

Changed branch from u/embray/cygwin/ticket-23059 to 609393a

@vbraun vbraun closed this as completed in 7369303 May 26, 2017
@embray embray mentioned this issue Feb 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: porting: cygwin p: blocker / 1 t: bug
Projects
None yet
Milestone
sage-8.0
Development

No branches or pull requests
4 participants
@embray @vbraun @tscrim @jhpalmieri