polymake does not build with gcc.7.1

[videlec]

The polymake experimental package does not compile with gcc (GCC) 7.1.1 (see attachment: polymake-3.1.log). In this thread on polymake forum upstream reports the same issue. We adapt a very simple patch proposed in the thread.

Upstream: Reported upstream. Developers acknowledge bug.

CC: @mkoeppe

Component: packages: experimental

Author: Vincent Delecroix

Branch/Commit: 25e2301

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/23289

[videlec]

comment:1

Attachment: polymake-3.1.log

[videlec]

Upstream: Not yet reported upstream; Will do shortly.

[videlec]

Changed upstream from Not yet reported upstream; Will do shortly. to Reported upstream. Developers acknowledge bug.

[videlec]

Branch: u/vdelecroix/23289

[videlec]

Commit: 25e2301

[videlec]

New commits:

25e2301

23289: patch for polymake compilation

[videlec]

comment:7

Not sure it is due to the patch but

$ sage -t polymake.py --optional=sage,polymake
**********************************************************************
File "polymake.py", line 814, in sage.interfaces.polymake.Polymake._eval_line
Failed example:
    p.N_LATTICE_POINTS                # optional - polymake
Expected:
    used package latte
      LattE (Lattice point Enumeration) is a computer software dedicated to the
      problems of counting lattice points and integration inside convex polytopes.
      Copyright by Matthias Koeppe, Jesus A. De Loera and others.
      http://www.math.ucdavis.edu/~latte/
    27
Got:
    27
**********************************************************************
1 item had failures:
   1 of  13 in sage.interfaces.polymake.Polymake._eval_line
    [245 tests, 1 failure, 22.05 s]
----------------------------------------------------------------------
sage -t --warn-long 75.7 polymake.py  # 1 doctest failed
----------------------------------------------------------------------

[vbraun]

comment:8

Positive review after you put in the author name...

[vbraun]

Reviewer: Volker Braun

[videlec]

comment:9

oups

[videlec]

Author: Vincent Delecroix

[vbraun]

Changed branch from u/vdelecroix/23289 to 25e2301