Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some curation in semidefinite programming html doc #23389

Closed
mforets mannequin opened this issue Jul 8, 2017 · 15 comments
Closed

Some curation in semidefinite programming html doc #23389

mforets mannequin opened this issue Jul 8, 2017 · 15 comments

Comments

@mforets
Copy link
Mannequin

mforets mannequin commented Jul 8, 2017

to do a couple of trivial docstring fixes in sdp.pyx.

Component: numerical

Keywords: semidefinite programming

Author: Marcelo Forets

Branch/Commit: 6775aa3

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/23389

@mforets mforets mannequin added this to the sage-8.0 milestone Jul 8, 2017
@mforets mforets mannequin added c: numerical labels Jul 8, 2017
@mforets
Copy link
Mannequin Author

mforets mannequin commented Jul 8, 2017

comment:1

the hyperlink to default_sdp_solver() is not available in semidefinite program because the file generic_sdp_backend.pyx is not shown. notice that the generic backend for MILP is included in the html reference. i suggest that we also include the one for SDP.

@mforets
Copy link
Mannequin Author

mforets mannequin commented Jul 8, 2017

New commits:

ab6d617typos in paragraphs
01ea990add generic_sdp_backend to html ref manual
64996b7typeset some equations

@mforets
Copy link
Mannequin Author

mforets mannequin commented Jul 8, 2017

Commit: 64996b7

@mforets
Copy link
Mannequin Author

mforets mannequin commented Jul 8, 2017

Author: Marcelo Forets

@mforets
Copy link
Mannequin Author

mforets mannequin commented Jul 8, 2017

Branch: u/mforets/23389

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 8, 2017

Changed commit from 64996b7 to 8d5131b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 8, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

8d5131badd missing INPUT and full stops

@mforets mforets mannequin added the s: needs review label Jul 8, 2017
@fchapoton
Copy link
Contributor

comment:5

I think there should be an empty line after

+        .. MATH::

@mforets
Copy link
Mannequin Author

mforets mannequin commented Jul 9, 2017

comment:6

Replying to @fchapoton:

I think there should be an empty line after

+        .. MATH::

the html doc displays fine even without the empty line between the directive and the equation, but let's add it to be consistent with most other places.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 9, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

6775aa3add extra space in MATH environments

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 9, 2017

Changed commit from 8d5131b to 6775aa3

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:8

ok

@mforets
Copy link
Mannequin Author

mforets mannequin commented Jul 10, 2017

comment:9

Replying to @fchapoton:

ok

Thanks for reviewing!

@vbraun
Copy link
Member

vbraun commented Jul 26, 2017

Changed branch from u/mforets/23389 to 6775aa3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants