Don't use SAGE_CYTHONIZED in sage_include_directories(sources=True)

[jdemeyer]

Currently, SAGE_CYTHONIZED is used by src/sage/env.py to determine some include directories while building Sage.

Since we want to get rid of SAGE_CYTHONIZED (#21535), a first step would be to move this bit to setup.py in order to concentrate all uses of SAGE_CYTHONIZED in one place.

CC: @mkoeppe @embray

Component: build

Author: Jeroen Demeyer

Branch/Commit: 33746a2

Reviewer: Erik Bray

Issue created by migration from https://trac.sagemath.org/ticket/23744

[jdemeyer]

Branch: u/jdemeyer/don_t_use_sage_cythonized_in_sage_include_directories_sources_true_

[jdemeyer]

Commit: 33746a2

[jdemeyer]

New commits:

33746a2

Don't use SAGE_CYTHONIZED in sage_include_directories()

[embray]

comment:3

I wonder what would happen if we also went ahead and deleted line 110 of sage.env:

_add_variable_or_fallback('SAGE_CYTHONIZED', opj('$SAGE_ROOT', 'src', 'build', 'cythonized'))

That could wait 'til a later change though. Looks good to me otherwise. I agree this is a good first step to removing it entirely.

[embray]

Reviewer: Erik Bray

[jdemeyer]

comment:4

Replying to @embray:

I wonder what would happen if we also went ahead and deleted line 110 of sage.env:

_add_variable_or_fallback('SAGE_CYTHONIZED', opj('$SAGE_ROOT', 'src', 'build', 'cythonized'))

Some doctests in src/sage_setup use that.

[vbraun]

Changed branch from u/jdemeyer/don_t_use_sage_cythonized_in_sage_include_directories_sources_true_ to 33746a2